Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format CI does not work on forked repositories #8326

Closed
lsh opened this issue Jul 29, 2022 · 8 comments · Fixed by #8356
Closed

Format CI does not work on forked repositories #8326

lsh opened this issue Jul 29, 2022 · 8 comments · Fixed by #8356
Labels
Bug 🐛 released This PR has been released by auto shipit

Comments

@lsh
Copy link
Member

lsh commented Jul 29, 2022

It seems that forked repositories do not work even when using the GitHub Secret as mentioned in the docs. This causes friction with contribution PRs as seen in #8282, #8302, and #8303.

@lsh lsh added the Bug 🐛 label Jul 29, 2022
@lsh
Copy link
Member Author

lsh commented Jul 29, 2022

cc @domoritz

@domoritz
Copy link
Member

Hmm, I didn't test this properly it seems. Did you look into how we may be able to fix it?

@lsh
Copy link
Member Author

lsh commented Jul 29, 2022

@jonmmease suggested adding pull_request to checks.yml as a possible solution.

@domoritz
Copy link
Member

Iirc that caused us to have to builds for internal prs. But things may have changed.

@domoritz
Copy link
Member

@lsh are you looking into this issue?

@lsh
Copy link
Member Author

lsh commented Aug 12, 2022

I haven't had a chance to take a crack at it but I can probably take a look tomorrow

@domoritz
Copy link
Member

Ah I remember the difficulty. We need to push to the branch after our check script and win a pull request trigger the target branch is not the right branch. So keep that in mind as you experiment.

@vega-org-bot
Copy link
Collaborator

🚀 Issue was released in v5.5.0 🚀

@vega-org-bot vega-org-bot added released This PR has been released by auto shipit and removed prerelease labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 released This PR has been released by auto shipit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants