fix: Escape Quotes in tooltip title
#9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Jul 19, 2023
kanitw
approved these changes
Jul 19, 2023
domoritz
reviewed
Jul 20, 2023
| @@ -88,7 +88,7 @@ export function tooltipData( | |||
| }; | |||
|
|
|||
| const title = fieldDef.title || defaultTitle(fieldDef, formatConfig); | |||
| const key = array(title).join(', '); | |||
| const key = array(title).join(', ').replaceAll(/"/g, '\\"'); | |||
There was a problem hiding this comment.
Huh, do we not have a utility method for this already? Does this problem not happen for other texts, axis labels or titles?
There was a problem hiding this comment.
I didn't see one, but maybe I didn't look in the right place. I'm not sure the other areas have the same problem since this one specifically generates a dictionary rather than acts as a value.
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently titles such as
"\"mytitle\""will cause the editor to break because it generates fields that look like:This PR escapes quotes to allow this case to pass.