Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ts and fix typing issues #9066

Merged
merged 2 commits into from Aug 31, 2023
Merged

fix: update ts and fix typing issues #9066

merged 2 commits into from Aug 31, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Aug 22, 2023

@arvind it looks like fields wasn't in interval selection configs but the docs and tests say it's a shared config option. Does this look right to you that I moved filelds?

@domoritz domoritz requested review from arvind and kanitw August 22, 2023 20:53
@domoritz domoritz changed the title fox: update ts and fix typing issues fix: update ts and fix typing issues Aug 22, 2023
@domoritz domoritz requested a review from lsh August 23, 2023 22:15
Copy link
Member

@lsh lsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@domoritz domoritz merged commit b421a44 into main Aug 31, 2023
10 checks passed
@domoritz domoritz deleted the dom/update-ts branch August 31, 2023 16:01
@joelostblom
Copy link
Contributor

This PR added the fields param to the interval selection config, but the docs say that interval selections only work with encodings and not fields. After this PR, fields now show up as an accepted parameter in interval selections, but setting it does not seem to have an effect Open the Chart in the Vega Editor. Should we remove fields from the interval config until it works to create a spec such as in the linked chart?

@arvind
Copy link
Member

arvind commented Sep 29, 2023

Sorry that this slipped off my radar (I was on vacation the week the PR was issued and then subsequently merged). fields is not a valid property of interval selections—they only take encodings as @joelostblom mentioned.

@domoritz
Copy link
Member Author

I see. We should undo the specific change then. https://vega.github.io/vega-lite/docs/selection.html#selection-props is incorrect then, right?

Screenshot 2023-09-29 at 16 34 10

alliefeldman pushed a commit to alliefeldman/vega-lite that referenced this pull request Oct 2, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants