Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider if cell.padding redundant with scale.padding #917

Closed
kanitw opened this issue Jan 11, 2016 · 2 comments
Closed

Consider if cell.padding redundant with scale.padding #917

kanitw opened this issue Jan 11, 2016 · 2 comments
Assignees
@kanitw
Milestone
1.0

Comments

@kanitw
Copy link
Member

kanitw commented Jan 11, 2016

No description provided.

@kanitw kanitw added this to the 1.0 milestone Jan 11, 2016
@kanitw kanitw mentioned this issue Jan 11, 2016
Closed
15 tasks
@kanitw kanitw assigned kanitw and unassigned kanitw Jan 11, 2016
@kanitw kanitw changed the title Consider if cell.padding redundant with scale.padding Revise Cell Config Jan 13, 2016
@kanitw
Copy link
Member Author

kanitw commented Jan 15, 2016

Although cell.padding is related with scale.padding, we use cell.padding because it is applied directly to layout calculation. scale.padding assumes a ratio between [0,1]; thus, it does not always lead to integer padding between cells.

@kanitw kanitw changed the title Revise Cell Config Consider if cell.padding redundant with scale.padding Jan 15, 2016
@kanitw
Copy link
Member Author

kanitw commented Jan 15, 2016

@domoritz maybe we should never pass ROW/COL scale.padding to the output Vega and remove cell.padding to avoid confusion?

kanitw added a commit that referenced this issue Jan 15, 2016
@kanitw
Apply scale.padding of row and column to our cell padding layou…
332319f 
…t calculation & remove the redundant `config.cell.padding`. Fixes #917
@kanitw kanitw closed this as completed Jan 15, 2016
@kanitw kanitw mentioned this issue Jan 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanitw kanitw

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@kanitw