Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Incorrectly Set to False #9190

Closed
PBI-David opened this issue Nov 29, 2023 · 0 comments · Fixed by #9237
Closed

Interactive Incorrectly Set to False #9190

PBI-David opened this issue Nov 29, 2023 · 0 comments · Fixed by #9237
Labels
Bug 🐛

Comments

@PBI-David
Copy link
Contributor

Relevant Stack Overflow: https://stackoverflow.com/questions/77569300/tooltip-not-working-on-using-scroller-in-vegalite/77569627?noredirect=1#comment136750697_77569627

Spec

image

Despite tooltip set to true in the top chart, no tooltip shows. The rendered Vega spec has interactive set to false. Setting this to true fixes the issue. I don't believe there is a way to do this in VL
@ChiaLingWeng ChiaLingWeng mentioned this issue Jan 30, 2024
Merged
domoritz pushed a commit that referenced this issue Jan 30, 2024
@ChiaLingWeng
fix: add markDef.tooltip for interactive check (#9237)
3891832 
close #9190 

For the original fail case, I found that adding tooltip in the encoding
field can solve the issue.
My assumption is the interactiveFlag missed to check markDef.tooltip
field, and thus add it in this PR
```
"encoding": {
        "x": {
          "field": "date",
          "type": "temporal",
          "scale": {"domain": {"param": "brush"}},
          "axis": {"title": ""}
        },
        "y": {"field": "price", "type": "quantitative"},
        "tooltip": [
          {"field": "price", "type": "quantitative"},
          {"field": "date", "type": "temporal"}
        ]
      }
```

https://github.com/vega/vega-lite/blob/ffec017f638103c37d0dbe72cac7d44f4f44b9d6/src/compile/mark/mark.ts#L377-L381

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add markDef.tooltip for interactive check ChiaLingWeng/vega-lite
1 participant
@PBI-David