-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some default values to config #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kanitw
changed the title
[WIP] Migrate default values to config -- a start toward eliminating schema.instantiate
Migrate some default values to config -- a start toward eliminating schema.instantiate
Feb 15, 2016
kanitw
changed the title
Migrate some default values to config -- a start toward eliminating schema.instantiate
[WIP] Migrate some default values to config -- a start toward eliminating schema.instantiate
Feb 15, 2016
kanitw
force-pushed
the
kw/config
branch
4 times, most recently
from
February 16, 2016 20:38
f0bc408
to
fb0251a
Compare
….instantiate (If all default values are in config and if we specify them explicitly, there is no need to maintain schema.instantiate.)
…g.cell` For faceted chart, `config.facet.unit` will override `config.unit`. This allows us to add stroke to each cell/unit of the faceted chart by default.
kanitw
force-pushed
the
kw/config
branch
4 times, most recently
from
February 17, 2016 00:38
00bd08d
to
eaafa5c
Compare
kanitw
changed the title
[WIP] Migrate some default values to config -- a start toward eliminating schema.instantiate
Migrate some default values to config
Feb 17, 2016
…roperties` + remove all `default: undefined`
domoritz
added a commit
that referenced
this pull request
Feb 17, 2016
Migrate some default values to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.mark.text
for placeholder textconfig.cell.grid*
toconfig.facet.grid.*
config.scene
because it's not that useful.config.cell
#1057 - Addconfig.unit
andconfig.facet.unit
& removeconfig.cell
config.facet.unit
will overrideconfig.unit
. This allows us to add stroke to each cell/unit of the faceted chart by default._config
to the model and change signature for compileMarkConfig, compileStackmodel.encoding()
rather thanmodel.spec().encoding
Bin
toBinProperties
because in factBin = boolean | BinProperties
+ remove alldefault: undefined
The only default value left in the schema is scale, which will be eliminated in a follow-up PR