Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some default values to config #1119

Merged
merged 11 commits into from
Feb 17, 2016
Merged

Migrate some default values to config #1119

merged 11 commits into from
Feb 17, 2016

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Feb 15, 2016

  • Migrate default value to config (If all default values are in config and if we specify them explicitly, there is no need to maintain schema.instantiate.)
    • text -- add config.mark.text for placeholder text
    • sort -- just stick in the code that undefined means ascending
    • data -- Hardcode default data format + auto parse file extension from the url
  • Migrate config.cell.grid* to config.facet.grid.*
  • Remove config.scene because it's not that useful.
  • Fix Revise config.cell #1057 - Add config.unit and config.facet.unit & remove config.cell
    • For faceted chart, config.facet.unit will override config.unit. This allows us to add stroke to each cell/unit of the faceted chart by default.
  • add _config to the model and change signature for compileMarkConfig, compileStack
  • Use model.encoding() rather than model.spec().encoding
  • Rename Bin to BinProperties because in fact Bin = boolean | BinProperties + remove all default: undefined

The only default value left in the schema is scale, which will be eliminated in a follow-up PR

@kanitw kanitw changed the title [WIP] Migrate default values to config -- a start toward eliminating schema.instantiate Migrate some default values to config -- a start toward eliminating schema.instantiate Feb 15, 2016
@kanitw kanitw assigned domoritz and unassigned domoritz Feb 15, 2016
@kanitw kanitw changed the title Migrate some default values to config -- a start toward eliminating schema.instantiate [WIP] Migrate some default values to config -- a start toward eliminating schema.instantiate Feb 15, 2016
@kanitw kanitw force-pushed the kw/config branch 4 times, most recently from f0bc408 to fb0251a Compare February 16, 2016 20:38
….instantiate

(If all default values are in config and if we specify them explicitly, there is no need to maintain schema.instantiate.)
…g.cell`

For faceted chart, `config.facet.unit` will override `config.unit`.  This allows us to add stroke to each cell/unit of the faceted chart by default.
@kanitw kanitw force-pushed the kw/config branch 4 times, most recently from 00bd08d to eaafa5c Compare February 17, 2016 00:38
@kanitw kanitw changed the title [WIP] Migrate some default values to config -- a start toward eliminating schema.instantiate Migrate some default values to config Feb 17, 2016
domoritz added a commit that referenced this pull request Feb 17, 2016
Migrate some default values to config
@domoritz domoritz merged commit 8c2c645 into master Feb 17, 2016
@domoritz domoritz deleted the kw/config branch February 17, 2016 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants