Generate schema from TypeScript classes (#1011 & #927) #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2016
domoritz
force-pushed
the
dom/glimpseio
branch
from
036b491
to
a371e6b
Compare
domoritz
changed the title
domoritz
force-pushed
the
dom/glimpseio
branch
3 times, most recently
from
f18a720
to
3579e22
Compare
domoritz
force-pushed
the
dom/glimpseio
branch
from
3579e22
to
4c2d974
Compare
| bandWidth?: number; | ||
| /** | ||
| * Applies spacing among ordinal elements in the scale range. The actual effect depends on how the scale is configured. If the __points__ parameter is `true`, the padding value is interpreted as a multiple of the spacing between points. A reasonable value is 1.0, such that the first and last point will be offset from the minimum and maximum value by half the distance between points. Otherwise, padding is typically in the range [0, 1] and corresponds to the fraction of space in the range interval to allocate to padding. A value of 0.5 means that the range band width will be equal to the padding width. For more, see the [D3 ordinal scale documentation](https://github.com/mbostock/d3/wiki/Ordinal-Scales). | ||
| */ | ||
| padding?: number; | ||
|
|
||
| // typical |
There was a problem hiding this comment.
Maybe we need to make the HEADER for semantic grouping clearer?
There was a problem hiding this comment.
Not sure what you mean. But seems to be something we can do over time as you said.
|
LGTM except minor comment about comment header. We can take care of that later too. |
domoritz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1011