Add lt, lte, gt, gte predicates (#3561) #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the filter predicates * Add tests for lt, lte, gt, gte filters * Clean up comments and fix typo * Increase stack-size while building the schema * Remove unused imports. * Add new schema. * Add docs for lt, lte, gt, gte transforms * Remove unnecessary comment. * Refactor to use FieldPredicateBase * Add docs with suggested changes * Add more explanation of string comparison * Fix explanation and remove field, timeUnit from range and oneOf * Value in backticks should be the actual operator, not an explanatory text.
|
cc: @invokesus I did a few minor fixes here too |
kanitw
changed the title
|
🎉 congrats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3452