Don't include extra encoding for composite mark in the main Encoding
#4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/composite-b
branch
from
9604ed5
to
851db0f
Compare
kanitw
commented
Feb 9, 2019
build/vega-lite-schema.json
Outdated
| @@ -4020,6 +3678,56 @@ | |||
| ], | |||
| "type": "string" | |||
| }, | |||
| "ErrorExtraEncoding": { | |||
There was a problem hiding this comment.
This is actually never referred anywhere. Probably an example of the bug in the generator. vega/ts-json-schema-generator#27
There was a problem hiding this comment.
Ok. I re-declare this in a way that this problem would no longer surface.
There was a problem hiding this comment.
Yeah, we sometimes output unnecessary stuff but it should not hurt (except for larger schemas).
There was a problem hiding this comment.
lol. Isn't Vega-Lite schema large enough?
There was a problem hiding this comment.
Oh, I'm not saying it's not a bug but it's not a blocking bug.
kanitw
force-pushed
the
kw/composite-b
branch
4 times, most recently
from
347a01b
to
ac2db0b
Compare
kanitw
changed the title
Encoding
kanitw
changed the title
EncodingEncoding
… and separate NormalizedUnitSpec from CompositeUnitSpec
kanitw
force-pushed
the
kw/composite-b
branch
from
ac2db0b
to
2701693
Compare
domoritz
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies #4440 and keep the number of
Encodingdeclarations small.In the schema, there are still simply
FacetedEncodingandEncoding.