Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graticule data generator. #4850

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Add graticule data generator. #4850

merged 6 commits into from
Apr 10, 2019

Conversation

jheer
Copy link
Member

@jheer jheer commented Apr 5, 2019

Changes:

  • Update data types to include both data sources and data generators.
  • Add generator for graticule GeoJSON data.
  • Add tests / examples for graticule generation.

Close #3337.

@jheer jheer requested review from domoritz and kanitw April 5, 2019 22:46
@jheer
Copy link
Member Author

jheer commented Apr 5, 2019

@domoritz When you get the chance, please feel free to check my TypeScript. For example, there is some redundancy between GraticuleParams in the Data definitions, and the vega-schema VgGraticuleTransform. Not sure if there is a preferred way to model these bits.

Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got the time to review thoroughly, but I response to the question about TS. :)

src/data.ts Show resolved Hide resolved
@jheer
Copy link
Member Author

jheer commented Apr 8, 2019

@domoritz or @kanitw, can I get a review on this PR? Thanks!

@kanitw
Copy link
Member

kanitw commented Apr 8, 2019

Yes, but FYI I'll traveling a lot this and next week though.
(I mostly get time to hack on the plane, but I can't do code review without access to Github.)

@jheer
Copy link
Member Author

jheer commented Apr 8, 2019

Totally understand, but I was planning to write curriculum materials that would build on these and related geo updates within the next week. So that would require both a review as well as a 3.2 release. I'm hoping this is possible.

@domoritz
Copy link
Member

domoritz commented Apr 8, 2019

If I have internet on the bus to Vancouver, I will do the review today.

Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge but either 1) add documentation or 2) create an issue to add documentation later.

@kanitw
Copy link
Member

kanitw commented Apr 9, 2019

If we want a release, we should have a documentation, so we can point the release note to the documentation?

@jheer
Copy link
Member Author

jheer commented Apr 9, 2019

Yes, I plan to add docs very soon, along with a few additional generators (sphere and sequence).

@jheer jheer merged commit 5590aa4 into master Apr 10, 2019
@jheer jheer deleted the jh/geo-graticule branch April 10, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants