-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graticule data generator. #4850
Conversation
@domoritz When you get the chance, please feel free to check my TypeScript. For example, there is some redundancy between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't got the time to review thoroughly, but I response to the question about TS. :)
Yes, but FYI I'll traveling a lot this and next week though. |
Totally understand, but I was planning to write curriculum materials that would build on these and related geo updates within the next week. So that would require both a review as well as a 3.2 release. I'm hoping this is possible. |
If I have internet on the bus to Vancouver, I will do the review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Feel free to merge but either 1) add documentation or 2) create an issue to add documentation later.
If we want a release, we should have a documentation, so we can point the release note to the documentation? |
Yes, I plan to add docs very soon, along with a few additional generators (sphere and sequence). |
Changes:
Close #3337.