feat: support axis/legend labelExpr + add example with month initials
#5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2019
kanitw
force-pushed
the
kw/axis.labelExpr
branch
3 times, most recently
from
adf9e0e
to
924d153
Compare
kanitw
force-pushed
the
kw/axis.labelExpr
branch
from
92ae883
to
62810e1
Compare
kanitw
changed the title
labelExpr + add example with month initialslabelExpr + add example with month initials
domoritz
approved these changes
Aug 5, 2019
src/axis.ts
Outdated
| @@ -185,6 +185,12 @@ export interface AxisOrientMixins { | |||
| export type AxisConfig = VlOnlyGuideConfig & AxisOrientMixins & VgAxisConfigNoSignals; | |||
|
|
|||
| export interface Axis extends AxisOrientMixins, VgAxisConfigNoSignals, Guide { | |||
| /** | |||
| * Vega expression for customizing labels text. | |||
| * Note that the string label and value can be assessed via the `label` and `value` of the backing `datum` object. | |||
There was a problem hiding this comment.
Suggested change
| * Note that the string label and value can be assessed via the `label` and `value` of the backing `datum` object. | |
| * Access the label text and value via the `label` and `value` of the `datum` object. |
src/legend.ts
Outdated
| @@ -110,6 +110,12 @@ export interface Legend | |||
| */ | |||
| encoding?: LegendEncoding; | |||
|
|
|||
| /** | |||
| * Vega expression for customizing labels text. | |||
| * Note that the string label and value can be assessed via the `label` and `value` of the backing `datum` object. | |||
There was a problem hiding this comment.
Suggested change
| * Note that the string label and value can be assessed via the `label` and `value` of the backing `datum` object. | |
| * Access the label text and value via the `label` and `value` of the `datum` object. |
Co-Authored-By: Dominik Moritz <domoritz@gmail.com>
Co-Authored-By: Dominik Moritz <domoritz@gmail.com>
Co-Authored-By: Dominik Moritz <domoritz@gmail.com>
Co-Authored-By: Dominik Moritz <domoritz@gmail.com>
|
Why didn't we add this for header? |
|
Headers require different code and I can't think of a convincing use case for headers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5122
Fix #5249