feat: top-level selections #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind
commented
Oct 1, 2020
arvind
force-pushed
the
as/selections-refactor
branch
2 times, most recently
from
3eefa06
to
fdd54a2
Compare
arvind
force-pushed
the
as/top-level-selections
branch
3 times, most recently
from
33d3a10
to
7aae32e
Compare
arvind
force-pushed
the
as/top-level-selections
branch
from
f860216
to
5919995
Compare
arvind
force-pushed
the
as/top-level-selections
branch
from
56643df
to
e29c4d3
Compare
arvind
force-pushed
the
as/top-level-selections
branch
from
1ba7919
to
2094317
Compare
kanitw
reviewed
Nov 15, 2020
| @@ -6,7 +6,7 @@ | |||
| "window": [{"op": "row_number", "as": "row_number"}] | |||
| }], | |||
| "hconcat": [{ | |||
| "selection": [{"name": "brush", "select": "interval"}], | |||
| "params": [{"name": "brush", "select": "interval"}], | |||
There was a problem hiding this comment.
I feel like "select": "interval" reads kinda weird. Wouldn't it be clearer if this is selection?
I could see that it doesn't make sense as the first commit in #6926 because having selection inside selection is kinda weird.
There was a problem hiding this comment.
I prefer select both because it's the verb form (and so reads more naturally, i.e., "select an interval") and because it's consistent with bind (rather than binding) which occurs at the same level.
kanitw
approved these changes
Nov 15, 2020
arvind
added a commit
that referenced
this pull request
Nov 16, 2020
* refactor: rename unit `selection` property to `params`. * feat: define selections at the top-level spec * feat: handle partial/nested paths for top-level selection `views`. * chore: update schema [CI] * chore: update examples [CI] * fix: add Parameter to unit params type signature for schema validation. * chore: update schema [CI] * Add comment about separate code path for assembling selection signals. Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.