Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support expr in projections #7060

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix: support expr in projections #7060

merged 2 commits into from
Nov 19, 2020

Conversation

domoritz
Copy link
Member

fixes #7056

@domoritz domoritz requested review from willium and a team November 19, 2020 00:27
willium
willium approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@willium willium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@domoritz
Copy link
Member Author

The example could probably be better but I will leave that for someone else.

@domoritz domoritz changed the title feat: support expr in projections fix: support expr in projections Nov 19, 2020
@domoritz domoritz merged commit d35650b into master Nov 19, 2020
@domoritz domoritz deleted the dom/proj-params branch November 19, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willium willium willium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support expr for projections
2 participants
@domoritz @willium