Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't include view stroke by default for non-cartesian plot #7665

Merged
merged 4 commits into from
Aug 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/compiled/airport_connections.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"padding": 5,
"width": 900,
"height": 500,
"style": "cell",
"data": [
{"name": "org_store"},
{
Expand Down Expand Up @@ -263,6 +262,5 @@
"range": [0, 1000],
"zero": true
}
],
"config": {"style": {"cell": {"stroke": null}}}
]
}
2 changes: 0 additions & 2 deletions examples/compiled/arc_donut.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"encode": {"update": {"stroke": {"value": null}}},
"data": [
{
"name": "source_0",
Expand Down
4 changes: 1 addition & 3 deletions examples/compiled/arc_facet.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,14 @@
{
"name": "cell",
"type": "group",
"style": "cell",
"from": {
"facet": {"name": "facet", "data": "source_0", "groupby": ["year"]}
},
"sort": {"field": ["datum[\"year\"]"], "order": ["ascending"]},
"encode": {
"update": {
"width": {"signal": "child_width"},
"height": {"signal": "child_height"},
"stroke": {"value": null}
"height": {"signal": "child_height"}
}
},
"marks": [
Expand Down
Binary file modified examples/compiled/arc_ordinal_theta.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/arc_ordinal_theta.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/arc_ordinal_theta.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
5 changes: 1 addition & 4 deletions examples/compiled/arc_params.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"type": "group",
"name": "concat_0_group",
"title": {"text": "Single Arc", "frame": "group"},
"style": "cell",
"encode": {
"update": {
"width": {"signal": "childWidth"},
Expand Down Expand Up @@ -115,7 +114,6 @@
"type": "group",
"name": "concat_1_group",
"title": {"text": "Stacked Arcs", "frame": "group"},
"style": "cell",
"encode": {
"update": {
"width": {"signal": "childWidth"},
Expand Down Expand Up @@ -165,6 +163,5 @@
"zero": true
}
],
"legends": [{"fill": "color", "symbolType": "circle", "title": "category"}],
"config": {"style": {"cell": {"stroke": null}}}
"legends": [{"fill": "color", "symbolType": "circle", "title": "category"}]
}
2 changes: 0 additions & 2 deletions examples/compiled/arc_pie.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"encode": {"update": {"stroke": {"value": null}}},
"data": [
{
"name": "source_0",
Expand Down
2 changes: 0 additions & 2 deletions examples/compiled/arc_pie_pyramid.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"encode": {"update": {"stroke": {"value": null}}},
"data": [
{
"name": "source_0",
Expand Down
2 changes: 0 additions & 2 deletions examples/compiled/arc_radial.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"encode": {"update": {"stroke": {"value": null}}},
"data": [
{"name": "source_0", "values": [12, 23, 47, 6, 52, 19]},
{
Expand Down
4 changes: 1 addition & 3 deletions examples/compiled/arc_radial_histogram.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down Expand Up @@ -165,6 +164,5 @@
"bins": {"signal": "layer_1_bin_maxbins_10_IMDB_Rating_bins"},
"zero": false
}
],
"config": {"style": {"cell": {"stroke": null}}}
]
}
Binary file modified examples/compiled/geo_choropleth.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_choropleth.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_choropleth.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{
"name": "source_1",
Expand Down
Binary file modified examples/compiled/geo_circle.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_circle.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_circle.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_constant_value.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_constant_value.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_constant_value.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{"name": "source_0", "url": "data/airports.csv", "format": {"type": "csv"}},
{
Expand Down
1 change: 0 additions & 1 deletion examples/compiled/geo_custom_projection.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 900,
"height": 560,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_graticule.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_graticule.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_graticule.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"data": [{"name": "source_0", "transform": [{"type": "graticule"}]}],
"projections": [
{
Expand Down
Binary file modified examples/compiled/geo_graticule_object.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_graticule_object.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_graticule_object.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"data": [
{"name": "source_0", "transform": [{"type": "graticule", "step": [15, 15]}]}
],
Expand Down
Binary file modified examples/compiled/geo_layer.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_layer.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_layer.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
1 change: 0 additions & 1 deletion examples/compiled/geo_layer_line_london.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 700,
"height": 500,
"style": "cell",
"encode": {"update": {"stroke": {"value": "transparent"}}},
"data": [
{
Expand Down
Binary file modified examples/compiled/geo_line.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_line.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_line.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_params_projections.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_params_projections.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_params_projections.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/geo_point.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_point.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 500,
"height": 300,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_repeat.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_repeat.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 0 additions & 3 deletions examples/compiled/geo_repeat.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
{
"type": "group",
"name": "child__row_population_group",
"style": "cell",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down Expand Up @@ -146,7 +145,6 @@
{
"type": "group",
"name": "child__row_engineers_group",
"style": "cell",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down Expand Up @@ -191,7 +189,6 @@
{
"type": "group",
"name": "child__row_hurricanes_group",
"style": "cell",
"encode": {
"update": {
"width": {"signal": "width"},
Expand Down
Binary file modified examples/compiled/geo_rule.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_rule.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_rule.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_sphere.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/compiled/geo_sphere.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion examples/compiled/geo_sphere.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"data": [
{"name": "source_0", "values": [{"type": "Sphere"}]},
{"name": "source_1", "transform": [{"type": "graticule"}]}
Expand Down
Binary file modified examples/compiled/geo_text.png
2 changes: 1 addition & 1 deletion examples/compiled/geo_text.svg

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion examples/compiled/geo_text.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 800,
"height": 500,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/geo_trellis.png
2 changes: 1 addition & 1 deletion examples/compiled/geo_trellis.svg

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion examples/compiled/geo_trellis.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
{
"name": "cell",
"type": "group",
"style": "cell",
"from": {
"facet": {"name": "facet", "data": "source_0", "groupby": ["group"]}
},
Expand Down
2 changes: 0 additions & 2 deletions examples/compiled/layer_arc_label.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
"padding": 5,
"width": 200,
"height": 200,
"style": "cell",
"encode": {"update": {"stroke": {"value": null}}},
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/point_angle_windvector.png
2 changes: 1 addition & 1 deletion examples/compiled/point_angle_windvector.svg

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion examples/compiled/point_angle_windvector.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"padding": 5,
"width": 615,
"height": 560,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/point_overlap.png
2 changes: 1 addition & 1 deletion examples/compiled/point_overlap.svg
1 change: 0 additions & 1 deletion examples/compiled/point_overlap.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 20,
"height": 20,
"style": "cell",
"data": [
{
"name": "source_0",
Expand Down
Binary file modified examples/compiled/test_single_point_color.png
2 changes: 1 addition & 1 deletion examples/compiled/test_single_point_color.svg
1 change: 0 additions & 1 deletion examples/compiled/test_single_point_color.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"padding": 5,
"width": 20,
"height": 20,
"style": "cell",
"data": [{"name": "source_0", "values": [{"a": 2}]}],
"marks": [
{
Expand Down
3 changes: 1 addition & 2 deletions examples/specs/airport_connections.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,5 @@
],
"projection": {"type": "albersUsa"},
"width": 900,
"height": 500,
"config": {"view": {"stroke": null}}
"height": 500
}
3 changes: 1 addition & 2 deletions examples/specs/arc_donut.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@
"encoding": {
"theta": {"field": "value", "type": "quantitative"},
"color": {"field": "category", "type": "nominal"}
},
"view": {"stroke": null}
}
}
3 changes: 0 additions & 3 deletions examples/specs/arc_facet.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,5 @@
"column": {"field": "year"},
"theta": {"field": "yield", "type": "quantitative", "aggregate": "sum"},
"color": {"field": "site", "type": "nominal"}
},
"view": {
"stroke": null
}
}
3 changes: 1 addition & 2 deletions examples/specs/arc_params.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,5 @@
"theta": {"field": "value", "type": "quantitative"},
"color": {"field": "category", "type": "nominal"}
}
}],
"config": {"view": {"stroke": null}}
}]
}
3 changes: 1 addition & 2 deletions examples/specs/arc_pie.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@
"encoding": {
"theta": {"field": "value", "type": "quantitative"},
"color": {"field": "category", "type": "nominal"}
},
"view": {"stroke": null}
}
}
3 changes: 1 addition & 2 deletions examples/specs/arc_pie_pyramid.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,5 @@
"order": {
"field": "order"
}
},
"view": {"stroke": null}
}
}
3 changes: 1 addition & 2 deletions examples/specs/arc_radial.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,5 @@
"theta": {"field": "data", "type": "quantitative", "stack": true},
"radius": {"field": "data", "scale": {"type": "sqrt", "zero": true, "rangeMin": 20}},
"color": {"field": "data", "type": "nominal", "legend": null}
},
"view": {"stroke": null}
}
}
3 changes: 1 addition & 2 deletions examples/specs/arc_radial_histogram.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@
"aggregate": "count",
"scale": {"type": "sqrt"}
}
},
"config": {"view": {"stroke": null}}
}
}
3 changes: 1 addition & 2 deletions examples/specs/layer_arc_label.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@
"encoding": {
"text": {"field": "category", "type": "nominal"}
}
}],
"view": {"stroke": null}
}]
}
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,5 @@
}
],
"width": 900,
"height": 500,
"config": {"view": {"stroke": null}}
"height": 500
}
1 change: 0 additions & 1 deletion examples/specs/normalized/arc_facet_normalized.vl.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"data": {"url": "data/barley.json"},
"facet": {"column": {"field": "year"}},
"spec": {
"view": {"stroke": null},
"mark": "arc",
"encoding": {
"theta": {"field": "yield", "type": "quantitative", "aggregate": "sum"},
Expand Down