Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multiple Detail #904

Merged
merged 9 commits into from
Jan 11, 2016
Merged

Support Multiple Detail #904

merged 9 commits into from
Jan 11, 2016

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jan 10, 2016

Fixed #864

  • bring back vl.fieldDef.field() so we can use it with detail array
  • replace stackChannels with stackFields in StackProperties (so we can have multiple fields for details)
  • modify methods in model.ts to check if encoding[channel] is an array

@kanitw kanitw assigned domoritz and unassigned domoritz Jan 10, 2016
@kanitw kanitw mentioned this pull request Jan 11, 2016
Merged
domoritz added a commit that referenced this pull request Jan 11, 2016
@domoritz
Merge pull request #904 from vega/kw/multi-detail
e77cdec 
Support Multiple Detail
@domoritz domoritz merged commit e77cdec into master Jan 11, 2016
@domoritz domoritz deleted the kw/multi-detail branch January 11, 2016 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kanitw @domoritz