Merge pull request #27 from boxfish/patch-1

Fix the Relay Transform visit order
vega · Dec 5, 2018 · 6ed7a8d · 6ed7a8d
1 parent a4cd58d
commit 6ed7a8d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/vega-dataflow/src/transforms/Relay.js b/packages/vega-dataflow/src/transforms/Relay.js
@@ -30,7 +30,12 @@ prototype.transform = function(_, pulse) {
 
   if (_.derive) {
     out = pulse.fork();
-
+
+    pulse.visit(pulse.REM, function(t) {
+      out.rem.push(lut[t._id]);
+      lut[t._id] = null;
+    });
+
     pulse.visit(pulse.ADD, function(t) {
       var dt = derive(t);
       lut[t._id] = dt;
@@ -40,11 +45,6 @@ prototype.transform = function(_, pulse) {
     pulse.visit(pulse.MOD, function(t) {
       out.mod.push(rederive(t, lut[t._id]));
     });
-
-    pulse.visit(pulse.REM, function(t) {
-      out.rem.push(lut[t._id]);
-      lut[t._id] = null;
-    });
   }
 
   return out;