Interpreter: Prevent evaluation of unsafe methods #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
force-pushed
the
interpreter-block-unsafe-methods
branch
4 times, most recently
from
f457672
to
2ce49c7
Compare
AMoo-Miki
force-pushed
the
interpreter-block-unsafe-methods
branch
from
2ce49c7
to
b71de74
Compare
|
@jheer Is there any other context or information we can provide to help expedite the review of this PR? |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in a CSP-compliant environment, unsafe evals are blocked by the browser. However, in an unsafe environment, blocking these methods from being interpreted would prevent their evaluation.