Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle consecutive escapes for splitAccessPath #3724

Merged
merged 1 commit into from Apr 25, 2023

Conversation

suchanlee
Copy link
Contributor

@suchanlee suchanlee commented Apr 19, 2023

There was a bug in splitAccessPaths where if there were consecutive \\s it would skip a character due to an extra increment in the index

For example:

  • \\a\\b\\c -> a\\bc (which is wrong but perhaps harmless)
  • \\[\\"foo\\"\\] -> Access path missing open bracket error due to skipping the last \\ following \\" and getting in the ] conditional although it's been escaped

Added tests for these cases

@suchanlee
Copy link
Contributor Author

Thanks a bunch for approving! What's the process for getting it merged?

@domoritz domoritz changed the title handle consecutive escapes for splitAccessPath fix: handle consecutive escapes for splitAccessPath Apr 21, 2023
@domoritz
Copy link
Member

@jheer usually merges and releases at some point. If you need this in your package now, I recommend patching the package dependency.

@jheer jheer merged commit f69be11 into vega:main Apr 25, 2023
3 checks passed
@jheer
Copy link
Member

jheer commented Apr 25, 2023

Thanks!

@suchanlee suchanlee deleted the suchanl/split-access-path branch April 25, 2023 23:39
@jheer jheer mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants