Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip description encoding channel for improved render performance #471

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

jonmmease
Copy link
Collaborator

@jonmmease jonmmease commented Mar 12, 2024

In the course of doing some benchmarking of pan and zoom on large scatterplots, I found that the description encoding that Vega-Lite adds by default has a significant performance penalty.

Here are some chrome profile flamegraphs for a 40k row version of the Vega-Lite pan/zoom example at https://vega.github.io/vega-lite/examples/selection_translate_scatterplot_drag.html

Default canvas renderer

Screenshot 2024-03-12 at 7 56 15 AM

With description and ariaRoleDescription encoding channels removed.

Screenshot 2024-03-12 at 7 55 34 AM

These encoding channels have no effect when used with the canvas renderer, which is what Vega-Altair uses.

@jonmmease jonmmease merged commit 3615368 into main Mar 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant