Unify duplicate transitive JavaScript dependencies, Drop Vega-Lite 4.17 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139
We download vl-convert's JavaScript dependencies from the SkyPack CDN using deno vendor. In some cases, this results in downloading multiple versions of transitive dependencies, like the
vega-functionspackage. Having multiple versions of packages loaded into the Deno runtime often works just fine, but in this case it caused the newgeoScaleexpression function to not be found.This PR detects duplicate packages and deletes old versions and remaps imports to reference the latest version.
This approach required dropping Vega-Lite 4.17, as it's no longer compatible with the latest vega package versions.