Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the VegaFusionRunTime from the vegafusion package #68

Closed
MarcSkovMadsen opened this issue Jan 30, 2022 · 1 comment · Fixed by #72
Closed

Provide the VegaFusionRunTime from the vegafusion package #68

MarcSkovMadsen opened this issue Jan 30, 2022 · 1 comment · Fixed by #72

Comments

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Jan 30, 2022

The only dependency the panel-vegafusion python package has to vegafusion python packages is the import of the vegafusion_jupyter.runtime.

image

The runtime is an instance of the VegaFusionRunTime defined in vegafusion_jupyter.

image

I believe its more natural that the VegaFusionRunTime is defined in the vegafusion package. In that way integration libraries have a more simple and natural dependency.

If not it would make sense for me to copy the VegaFusionRunTime implementation to panel-vegafusion package and drop the dependency on vegafusion_jupyter.

Please let me know what you would prefer @jonmmease ? Thanks.

@jonmmease
Copy link
Collaborator

Yeah, there are a couple of things that should be moved out of vegafusion-jupyter. In addition to the runtime, the data transformer that writes DataFrames as feather files will apply across extension types.

Right now vegafusion-python is a pure Rust package and I haven't yet worked through how to combine pure Python modules in the same package. I doubt it's that difficult, but I haven't tried. In any case, I'd say go ahead and copy over what you need right now, and that will help inform the refactoring later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants