Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN packages using GNU Fortran extensions unnecessarily #7

Closed
jarioksa opened this issue Jun 19, 2023 · 3 comments
Closed

CRAN packages using GNU Fortran extensions unnecessarily #7

jarioksa opened this issue Jun 19, 2023 · 3 comments
Assignees

Comments

@jarioksa
Copy link
Contributor

Brian Ripley sent an email saying:

largely it seems from legacy (pre-F77 or pre-F90) code. That is

TSSS bgw cepreader deSolve dfsaneacc multitaper rexpokit timsac

and others reported separately. See the 00README.txt and installation logs at https://www.stats.ox.ac.uk/pub/bdr/f2008/ .

Please correct before 2023-07-20 to safely retain your package on CRAN (that is just before the CRAN summer break).

This seems to concern functions getarg and exit that are flagged as GNU extensions also in the comments of src/cepin.f. The getarg should be easily replaced with Fortran 2003 standard get_command_argument (see https://gcc.gnu.org/onlinedocs/gfortran/GETARG.html). I am not sure about exit.

@jarioksa jarioksa self-assigned this Jun 19, 2023
jarioksa added a commit that referenced this issue Jun 20, 2023
@jarioksa
Copy link
Contributor Author

jarioksa commented Jun 20, 2023

I have fixed this in my system, but my system is on the rare side (GNU Fortran (GCC) 12.0.1 20220312 (experimental), for ARM64 or Apple Silicon). If you have any other system, please check and we can send this in CRAN. In particular, Windows checks are useful. The fixes were merged to the master branch.

Added note: I implemented R CMD check in gh-actions, and runs OK in R release on ubuntu, macOS & Windows, and in oldrel and devel on ubuntu. I'll still run win-builder checks, and wait for a day or two, and then push this to CRAN.

@gavinsimpson
Copy link
Contributor

All the checks completed without issue on GH Actions, including the Windows build. I'll try on my Linux box today and you could try sending it to winbuilder

@jarioksa
Copy link
Contributor Author

Closed with the new CRAN release 1.2-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants