This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
Add auto-generated Typescript files #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashleyvega the missing piece here is a typescript index file. I've hand coded one but it should be generated in the same way as index.js is - I'm going to push commit with the static version, and the relevant |
To make dependent packages recognise the types, we need to add a declaration that there are indeed types to look for. This commit adds an `index.d.ts` file in the root that contains references to the .d.ts files generated in a previous commit in this branch. It also adds a reference to that file in `package.json`, which is The Correct Way, even though `index.d.ts` should be sufficient. However! This requires a follow up commit that generates the `index.d.ts` file in the build script, rather than leaving it hardcoded. The current file is good for now, but should be removed and generated at build. - Add `types` field in `package.json` - Add hardcoded `index.d.ts`
- Remove .d.ts extension from all imports - Fix paths in two imports
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses https://github.com/improbable-eng/ts-protoc-gen to generate:
--ts_out="$out_dir")--ts_out="service=grpc-node:$out_dir")--ts_out="service=grpc-web:$out_dir")Closes #90.