-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast component #1677
Comments
Proposed design here: https://www.figma.com/file/K49Nx7XfocShhHcwwQzQkm/Console-V2?node-id=3672%3A35294 Current thinking is that toasts would only be used to communicate things to the user something that the system has done - Not prompt them to do something. Proposed toast structureBehaviour
ExamplesPositionQuestionsWhat happens when you’re not there when event happens - ideally you'd get the notifications when you next log in, but I'd imagine that's a lot more work? |
I've done a quick mockup of how the transitions would ideally work: https://codepen.io/PeteWilliams/pen/mdKybbR Specification:
|
NICE! Will jump on this tomorrow - today has run away with me with swag stuff. |
Hi @mattrussell36 @PeteWilliams I did some research into UI design for toasts and then developed the UX work Pete has done (thanks!). I've drawn up three initial options that I'd like to get feedback on... I'm drawn to the first option, but aware the third option is more aligned with other Vega UI elements. Any thoughts? Happy to explore further if this hasn't hit the right note yet! Cheers, |
I like 1 and 3. Would be good to see them in situ to see how they'd look in Console. Probably best to stick to the existing orange and red colours for warning and error. Blue could be a useful option for info though, maybe for things like notifications promoting new features or incentives in the future. The ones with a secondary line of content need more contrast for legibility though, and it'd be good to have the market name stand out a bit more. |
Thanks Pete - I've made some revisions and also placed both in situ for comparison. You can view the files here: https://www.figma.com/file/deV7EBxvTF4ggdsKVVosfr/Console-V2?node-id=631%3A4624 Let me know your thoughts @PeteWilliams @mattrussell36 |
Looks good @bigfandavid. I think I prefer option 1, but no strong preference. Wasn't expecting it to be white on the dark theme, but don't have a problem with it as it stands out nicely. |
The Chore
We need a design for a generic toast component added to the UI toolkit. This will initially be used for showing transaction statuses, but it should be flexible enough for other use cases too.
Tasks
Additional details / background info
Note: Radix now has a toast component which we should probably leverage to ensure a11y and interaction concerns are covered.
We may need both a Toast component and possibly a Toaster component to handle display of multiple toasts (probably stacking them as it will be possible to execute multiple tx simultaneously)
The text was updated successfully, but these errors were encountered: