Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vega transaction toasts #1679

Closed
5 of 11 tasks
mattrussell36 opened this issue Oct 7, 2022 · 1 comment · Fixed by #2382
Closed
5 of 11 tasks

Vega transaction toasts #1679

mattrussell36 opened this issue Oct 7, 2022 · 1 comment · Fixed by #2382
Assignees

Comments

@mattrussell36
Copy link
Collaborator

mattrussell36 commented Oct 7, 2022

Story

As a user
I want vega transactions to be shown as toasts
So that I can continue to use the app whilst waiting for a tx to complete

Acceptance Criteria

  • I am prompted via dialog to complete the transaction in wallet
  • I am immediately shown a rejected transaction (when rejected by wallet immediately)
  • If the transaction was accepted by the wallet, I can still use the application and am not blocked by an overlay
  • If the transaction is accepted I am shown a toast with the tx hash, indicating its pending
  • I can execute multiple transactions one after the other
  • When a transaction result is received, notify state by toast

Tasks

Additional information

  • We may want to create a new hook/store for this. Say a useVegaTransactionV2 to make development and migration to the new pattern easier and more incremental
@PeteWilliams
Copy link
Contributor

Some thoughts on this here: https://www.figma.com/file/K49Nx7XfocShhHcwwQzQkm/Console-V2?node-id=3672%3A35294

In summary, I'd suggest the prompt to approve in their wallet remains a dialog, and then the pending and result states are shown in toasts.

One area that complicates things is the 2-part processes such as deposits and withdrawals - you're in a modal for part 1, then you wait for the confirmation, and then you get another modal for part 2. I'm not sure going to toasts inbetween makes sense - what would happen to the modal while that's happening? Might make more sense to show the pending/confirmation states in modals in these scenarios… one to discuss in crit and with devs.

@PeteWilliams PeteWilliams removed their assignment Nov 8, 2022
@bigfandavid bigfandavid self-assigned this Nov 9, 2022
@asiaznik asiaznik self-assigned this Nov 9, 2022
@mattrussell36 mattrussell36 changed the title Vega/Ethereum transaction state as toasts Vega transaction state as toasts Nov 16, 2022
@mattrussell36 mattrussell36 changed the title Vega transaction state as toasts Vega transaction toasts Nov 16, 2022
@mattrussell36 mattrussell36 assigned bglownia and unassigned asiaznik Nov 28, 2022
@mattrussell36 mattrussell36 changed the title Vega transaction toasts [console] Vega transaction toasts Nov 30, 2022
@asiaznik asiaznik self-assigned this Nov 30, 2022
@pennyandrews pennyandrews changed the title [console] Vega transaction toasts Vega transaction toasts Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
6 participants