Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transaction store and toasts #2382

Merged
merged 13 commits into from
Dec 21, 2022
Merged

Conversation

asiaznik
Copy link
Member

@asiaznik asiaznik commented Dec 9, 2022

Related issues 🔗

Closes #1679

Demo 📺

Screen.Recording.2022-12-09.at.16.16.10.mov

bglownia and others added 2 commits December 9, 2022 19:04
feat: replace useStoredEthereumTransaction with useEthTransactionManager

feat: add event bus subsciption to vega transaction store

feat: handle order cancellation

feat: rename Deposit, Order and Withdraw status field to be unique

Revert "feat: rename Deposit, Order and Withdraw status field to be unique"

This reverts commit f0b314d.

feat: split transaction update subscription

feat: handle order and deposit transaction

feat: handle withdrawal creation through transaction store

feat: handle withdraw approval

feat: handle panding withdrawls, add createdAt

feat: handle transaction toast/dialog dismissal

feat: add use vega transaction store tests

feat: add use vega transaction store tests

feat: add use vega transaction menager tests

feat: add use vega transaction menager tests

feat: add use vega transaction updater tests

feat: improve use vega transaction updater tests

feat: add use eth transaction store

feat: add use eth withdraw approvals store

feat: add use eth transaction updater tests

fixed tests
feat: toasts

feat: toasts
@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for liquidity-provision-dashboard ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/liquidity-provision-dashboard/deploys/63a2c956f024040009fe07dd
😎 Deploy Preview https://deploy-preview-2382--liquidity-provision-dashboard.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for vega-ui-toolkit ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/63a2c9566514d3000a8c82b7
😎 Deploy Preview https://deploy-preview-2382--vega-ui-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for vega-tools ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/vega-tools/deploys/63a2c956b814ba00098cbfd8
😎 Deploy Preview https://deploy-preview-2382--vega-tools.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for vega-trading-app ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/63a2c956b814ba00098cbfd3
😎 Deploy Preview https://deploy-preview-2382--vega-trading-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for market-depth ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/market-depth/deploys/63a2c95669d31f000824de11
😎 Deploy Preview https://deploy-preview-2382--market-depth.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@asiaznik asiaznik marked this pull request as ready for review December 9, 2022 18:23
@asiaznik asiaznik requested a review from a team as a code owner December 9, 2022 18:23
@cypress
Copy link

cypress bot commented Dec 9, 2022



Test summary

104 0 3 0


Run details

Project frontend-monorepo
Status Passed
Commit f8d7657 ℹ️
Started Dec 21, 2022 9:14 AM
Ended Dec 21, 2022 9:18 AM
Duration 04:25 💡
OS Linux Ubuntu -
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for console-mainnet-mirror ready!

Name Link
🔨 Latest commit f3a73ff
🔍 Latest deploy log https://app.netlify.com/sites/console-mainnet-mirror/deploys/63a2c95669d31f000824de16
😎 Deploy Preview https://deploy-preview-2382--console-mainnet-mirror.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bglownia bglownia force-pushed the feat/transaction-store-and-toasts branch from 3339ce9 to 6ed7cee Compare December 13, 2022 15:11
Copy link
Collaborator

@mattrussell36 mattrussell36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big chunk of work here! My main blocking chain is the use of Web3Containers everywhere, which shouldn't be required anymore as we now have the Web3ReactProvider wrapping the entire app

apps/trading/pages/_app.page.tsx Outdated Show resolved Hide resolved
libs/withdraws/src/lib/create-withdrawal-dialog.tsx Outdated Show resolved Hide resolved
libs/withdraws/src/lib/pending-withdrawals-table.tsx Outdated Show resolved Hide resolved
libs/withdraws/src/lib/withdrawal-feedback.tsx Outdated Show resolved Hide resolved
@mattrussell36
Copy link
Collaborator

Just noticed this z-index issue with the order book header

Screenshot 2022-12-14 at 21 47 01

@asiaznik asiaznik merged commit 87e1f99 into develop Dec 21, 2022
@mkjmdski mkjmdski deleted the feat/transaction-store-and-toasts branch May 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vega transaction toasts
4 participants