Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable margin estimations in deal ticket #5308

Closed
1 task done
mattrussell36 opened this issue Nov 17, 2023 · 0 comments · Fixed by #5317
Closed
1 task done

Re-enable margin estimations in deal ticket #5308

mattrussell36 opened this issue Nov 17, 2023 · 0 comments · Fixed by #5317
Assignees
@mattrussell36

Comments

@mattrussell36
Copy link
Collaborator

mattrussell36 commented Nov 17, 2023 •
edited

The Chore

R-enable margin estimations in the deal ticket when vegaprotocol/vega#10119 and vegaprotocol/vega#10122 are deployed on mainnet

Margin estimations were disabled in #5305 due to a core bug.

Tasks

  • Remove conditional rendering of margin estimation values

Additional details / background info

https://vegaprotocol.slack.com/archives/C037STCKMGC/p1700157287721849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrussell36 mattrussell36

Labels
None yet
Projects
Frontend Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deal-ticket): re-enable margin estimates for perps vegaprotocol/frontend-monorepo
2 participants
@mattrussell36 @gordsport