Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perps: use same check for theoretical and actual funding payment #10119

Merged
merged 4 commits into from Nov 17, 2023
Merged

Perps: use same check for theoretical and actual funding payment #10119

merged 4 commits into from Nov 17, 2023

Conversation

witgaw
Copy link
Member

@witgaw witgaw commented Nov 16, 2023 •
edited

Close #10120, #10121

@witgaw
refactor: use same check for theoretical
17a6502 
and acutal funding payment
@witgaw witgaw requested a review from a team as a code owner November 16, 2023 22:17
@witgaw witgaw self-assigned this Nov 16, 2023
@witgaw witgaw linked an issue Nov 16, 2023 that may be closed by this pull request
EstimatePosition API returns incorrect margin estimate with perps edge case #10121
Closed
@wwestgarth
Copy link
Contributor 

{
    "system-tests":"fix-perp-test"
}

@jeremyletang jeremyletang merged commit a0c8446 into develop Nov 17, 2023
15 checks passed
@jeremyletang jeremyletang deleted the fix-perps-margin-estimate branch November 17, 2023 12:54
jeremyletang added a commit that referenced this pull request Nov 17, 2023
@jeremyletang
Merge pull request #10119 from vegaprotocol/fix-perps-margin-estimate
26af368 
Perps: use same check for theoretical and actual funding payment
This was referenced Nov 17, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

@ValentinTrinque ValentinTrinque ValentinTrinque left review comments

Assignees

@witgaw witgaw

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@witgaw @wwestgarth @jeremyletang @ValentinTrinque