Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct vote value string for casting vote #3521

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

mattrussell36
Copy link
Collaborator

Related issues πŸ”—

Closes #3520

Description ℹ️

Fixes casting a vote being broken in the token app.

Technical πŸ‘¨β€πŸ”§

The wrong string was being passed in the transaction payload, not picked up on because the types were also incorrect

@mattrussell36 mattrussell36 requested a review from a team as a code owner April 23, 2023 12:40
@netlify
Copy link

netlify bot commented Apr 23, 2023

βœ… Deploy Preview for vega-explorer ready!

Name Link
πŸ”¨ Latest commit 670b0ac
πŸ” Latest deploy log https://app.netlify.com/sites/vega-explorer/deploys/6445272db091fe0008ed1bc3
😎 Deploy Preview https://deploy-preview-3521--vega-explorer.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 23, 2023

βœ… Deploy Preview for token-monorepo ready!

Name Link
πŸ”¨ Latest commit 670b0ac
πŸ” Latest deploy log https://app.netlify.com/sites/token-monorepo/deploys/6445272df215250008703bd4
😎 Deploy Preview https://deploy-preview-3521--token-monorepo.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@edd edd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks fine. Is there anything that we could automate to make the types get updated more reliably?

@mattrussell36 mattrussell36 merged commit 49d6e66 into main Apr 23, 2023
1 of 3 checks passed
@edd edd deleted the fix/3520-voting-broken branch April 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants