Feat/427: Serve explicit environments #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔮 Deploy Preview for vega-explorer canceled.
|
✅ Deploy Preview for vega-trading-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👷 Deploy Preview for vega-ui-toolkit processing.
|
✅ Deploy Preview for token-dapp-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for simple-trading ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
dexturr
reviewed
May 19, 2022
notbot00
commented
May 20, 2022
dexturr
approved these changes
May 20, 2022
MadalinaRaicu
approved these changes
May 23, 2022
dexturr
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues 🔗
Closes #427
Description ℹ️
Added a new executor which proxies the
@nrwl/web:dev-server. Now when we run the serve, we can pass in a custom env, which will make the executor load the relevant.env.{name}from the project root.e.g.
This will now pick up the env variables put in the
.env.stagnet1file and applies it to the app.There's an open issue related to this here: nrwl/nx#7729
Technical
The current solution works only for apps using the
@nrwl/web:dev-server. This excludes the trading app, as that one uses a nextjs executor.