Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trading): pagination limit for candles #5169

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

MadalinaRaicu
Copy link
Contributor

@MadalinaRaicu MadalinaRaicu commented Nov 1, 2023

Related issues πŸ”—

Closes #5168

Description ℹ️

By adding { pagination: { last: 1000} to the query we're able to get the latest candles.

Demo πŸ“Ί

After:

image

Before:

Screenshot 2023-11-01 at 14 37 42

Technical πŸ‘¨β€πŸ”§

Details of technical implementation that reviewers may need to be aware of, if applicable.

@MadalinaRaicu MadalinaRaicu marked this pull request as ready for review November 1, 2023 15:43
@MadalinaRaicu MadalinaRaicu requested review from a team as code owners November 1, 2023 15:43
Copy link

github-actions bot commented Nov 1, 2023

1 similar comment
Copy link

github-actions bot commented Nov 1, 2023

@mattrussell36 mattrussell36 merged commit d4f50eb into develop Nov 1, 2023
19 of 20 checks passed
@bwallacee
Copy link
Contributor

LGTM

@edd edd deleted the fix/candles-pagination-last branch April 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Candle data incorrect since 0.73.1 deployment
5 participants