Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(trading): team id on team page #6280

Merged
merged 2 commits into from
Apr 23, 2024
Merged

chore(trading): team id on team page #6280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f65fee
chore(trading): team id on team page
asiaznik Apr 23, 2024
80b083f
chore(trading): fix teams headline test
bwallacee Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions apps/trading/client-pages/competitions/competitions-team.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,19 @@ const TeamPage = ({
</span>{' '}
({t('epoch')}: {team.createdAtEpoch})
</div>
<div>
<span>
{t('ID')}:{' '}
<span className="text-vega-cdark-600 dark:text-vega-clight-600 ">
{truncateMiddle(team.teamId)}
</span>{' '}
</span>
<CopyWithTooltip text={team.teamId}>
<button className="h-4 w-4">
<VegaIcon name={VegaIconNames.COPY} size={14} />
</button>
</CopyWithTooltip>
</div>
</div>
</div>
</header>
Expand Down
2 changes: 1 addition & 1 deletion apps/trading/e2e/tests/teams/test_teams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def test_team_page_headline(team_page: Tuple[Page, str, str, VegaServiceNull]):
page, team_name, team_id, vega = team_page
expect(page.get_by_test_id("team-name")).to_have_text(team_name)
expect(page.get_by_test_id("icon-open-external").nth(1)).to_be_visible()
expect(page.get_by_test_id("icon-copy")).to_be_visible()
expect(page.get_by_test_id("icon-copy").first).to_be_visible()
expect(page.get_by_test_id("members-count-stat")).to_have_text("4")

expect(page.get_by_test_id("total-games-stat")).to_have_text("1")
Expand Down
3 changes: 2 additions & 1 deletion libs/i18n/src/locales/en/trading.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@
"Hoarder reward multiplier": "Hoarder reward multiplier",
"How it works": "How it works",
"I want a code": "I want a code",
"ID": "ID",
"Improve vega console": "Improve vega console",
"Inactive": "Inactive",
"Index Price": "Index Price",
Expand Down Expand Up @@ -271,12 +272,12 @@
"No members": "No members",
"No MetaMask version that supports snaps detected. Learn more about <0>MetaMask Snaps</0>": "No MetaMask version that supports snaps detected. Learn more about <0>MetaMask Snaps</0>",
"No open orders": "No open orders",
"No order history": "No order history",
"No orders": "No orders",
"No party accepts any liability for any losses whatsoever.": "No party accepts any liability for any losses whatsoever.",
"No perpetual markets.": "No perpetual markets.",
"No proposed markets": "No proposed markets",
"No referral program active": "No referral program active",
"No order history": "No order history",
"No rewards": "No rewards",
"No rows": "No rows",
"No thanks": "No thanks",
Expand Down
Loading