fix(explorer,proposals): handle batch proposals in proposals table #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edd
commented
Jun 28, 2024
| valueFormatter: ({ | ||
| value, | ||
| }: VegaValueFormatterParams< | ||
| ProposalListFieldsFragment, | ||
| 'terms.enactmentDatetime' | ||
| 'terms.closingDatetime' |
There was a problem hiding this comment.
Note: this diff is a little misleading, I definitely didn't just change the enactment column to show closing
edd
force-pushed
the
fix/6555-fix-proposal-provider
branch
2 times, most recently
from
e42f734
to
8452187
Compare
edd
force-pushed
the
fix/6555-fix-proposal-provider
branch
from
8452187
to
8ac1ecb
Compare
edd
added a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues 🔗
Closes #6555
Description ℹ️
The Proposals lib (used only in Explorer) was using a deprecated GraphQL type to select proposals. This resulted in Batch Proposals not appearing in the proposal list. This PR updates the graphQL query & handles batch proposals for the table.
Note that the Enacted column has been removed. Each proposals in a sub proposal has an individual enactment time, which makes this column not applicable. I made the decision to remove the column, because this component the enactment time is available in the JSON dialog, and most recent proposals are in batches which made this column useless. The
Statuscolumn does the job of indicating if the proposal has hit its enactment period.Demo 📺
Batches now appear in the list
JSON view is populated with the subproposals