Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Add validation on commands for ids and pubkeys #500

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Add validation on commands for ids and pubkeys #500

merged 3 commits into from
Jul 14, 2022

Conversation

jeremyletang
Copy link
Member

close #499

@jeremyletang jeremyletang marked this pull request as ready for review July 13, 2022 16:46
@jeremyletang jeremyletang requested a review from a team as a code owner July 13, 2022 16:46
@jeremyletang jeremyletang changed the title fix: add announce node validation Add validation on commands for ids and pubkeys Jul 13, 2022
AnExsomnis
AnExsomnis reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@AnExsomnis AnExsomnis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for a change for the purpose of consistency in conditions checks.

commands/announce_node.go Show resolved Hide resolved
commands/transaction.go Show resolved Hide resolved
@AnExsomnis AnExsomnis merged commit 2c2ab67 into develop Jul 14, 2022
@AnExsomnis AnExsomnis deleted the feature/499-add-id-and-pkeys-validations branch July 14, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AnExsomnis AnExsomnis AnExsomnis left review comments

@pscott31 pscott31 pscott31 approved these changes

Assignees

@jeremyletang jeremyletang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation on vega IDs / pubkey
3 participants
@jeremyletang @AnExsomnis @pscott31