-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
sources/vega/data/v1/spec.proto
Outdated
DataSpecConfiguration oracle = 1; | ||
DataSpecConfiguration bridge = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get what these 2 are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a oneof setting for different type of external spec configuration - we can define an oracle or a bridge.
But this was added in order to show how different external types would be treated anyway, so I'll just leave oracle for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the unused one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the commands might need updating relative to these changes.
35d513e
to
d084223
Compare
@jeremyletang , Addressed all of your comments and rebased with develop |
Those changes looks good to me @AnExsomnis, let's move them over onto the vega repo on a new PR please. thanks. |
closing as done in: |
close vegaprotocol/vega#5714
This PR redefines the proto types related to oracles following the logic presented in vegaprotocol/specs#1161
changes introduced:
For all external data sources - we care about pubkeys and filters -> so we apply same properties for all (this follows the logic in feat: redefine data sourcing concepts. specs#1161)
=> Everywhere where we have oracle definitions we use the generic data source type instead of custom oracle type
There is an option where we can embed generic data type into the oracle type - if we really need specific properties for oracles. Same of course can be applied further for different groups of oracles (ETH, or not), bridges as a separate group of external sources, whatever we would need.
The idea behind the changes is: