Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create multis user update #1619

Draft
wants to merge 144 commits into
base: cosmicelevator
Choose a base branch
from
Draft

Create multis user update #1619

wants to merge 144 commits into from

Conversation

Vegaklaus
Copy link
Contributor

@Vegaklaus Vegaklaus commented Mar 10, 2023 •
edited by gordsport
Loading

close #1503 .

davidsiska-vega and others added 30 commits January 19, 2023 10:58
@davidsiska-vega
fix: bring market.liquidity.targetstake.triggering.ratio in line with…
cdcfd4b 
… implementation
@gordsport
fix: duplicate AC codes in 0069-VCBS (#1536)
d993621
@davidsiska-vega
chore: trailing spaces
c2cb333
@davidsiska-vega
fix: remove the unused netparam; not liking that
30a078d
@davidsiska-vega
Merge branch 'master' into fix_0035-AC-009
31ff6b9
@davidsiska-vega
Merge pull request #1534 from vegaprotocol/fix_0035-AC-009
11b375e 
fix: bring market.liquidity.targetstake.triggering.ratio in line with…
@gordsport
chore: remove untestable AC from 0018 (#1530)
4ff8a82
@wwestgarth
chore: reword 0063-VALK-013
fd16996
@wwestgarth
Merge pull request #1540 from vegaprotocol/clarify-key-rotation-acs
d26a6c5 
chore: reword 0063-VALK-013
@vega-paul
Update 0035-LIQM-liquidity_monitoring.md (#1539)
5c5cd6a 
* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md
@gordsport
fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)
9dba312
@RomanLeca
Update 0011-NP-CLIE-client-interaction-tests.md
fad492e
@davidsiska-vega
feat: allow any key to request multisg signers update bundle
f7b5aad
@davidsiska-vega
feat: clarify spam status
c98ec28
@RomanLeca
Merge pull request #1544 from vegaprotocol/RomanLeca-patch-17
fa23993 
Update 0011-NP-CLIE-client-interaction-tests.md
@davidsiska-vega
Merge branch 'master' into feat-any-vega-key-can-get-multisig-update-…
b8ffe02 
…bundle
@davidsiska-vega
Merge pull request #1545 from vegaprotocol/feat-any-vega-key-can-get-…
2636658 
…multisig-update-bundle

feat: allow any key to request multisg signers update bundle
@witgaw
refactor: let max oi drop during auciton
c5423e5
@witgaw
Merge pull request #1546 from vegaprotocol/move-implemented-bit
960ace6 
refactor: let max oi drop during auciton
@candida-d
Wording tweaks for spam protection spec (#1548)
0890679 
* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section
@candida-d
fix spelling in spam protection spec (#1553)
2069690
@Vegaklaus
Update 0069-VCBS-validators_chosen_by_stake.md
ff8266a 
Added pending validator to VCBS-59
@Vegaklaus
Update 0069-VCBS-validators_chosen_by_stake.md
2829019 
Clarification on 0059
@Vegaklaus
Update 0062-SPAM-spam_protection.md
7e8aaf6
@Vegaklaus
Update 0062-SPAM-spam_protection.md
f9f0364 
fixed link to defaults.go
@gordsport
Add quality checks to the makefile (#1556)
1ba47f4
@gordsport
fix: broken links in the specs (#1557)
01e6b3f
@davidsiska-vega
fix: remove broken kraken link
f36cdf6
@davidsiska-vega
Merge pull request #1558 from vegaprotocol/remove-broken-kraken-link
5405196 
fix: remove broken kraken link
@witgaw
refactor: clarify 0042-LIQF-018
15ad1cc
Jiajia-Cui and others added 10 commits March 7, 2023 09:55
@Jiajia-Cui
Merge pull request #1609 from vegaprotocol/0042-typo
7932524 
feat: fix typo in 0042
@gordsport
fix: spelling errors
e354d8a
@Vegaklaus
Merge branch 'master' into Vegaklaus-patch-22
fd9d6e6
@ValentinTrinque
Merge pull request #1608 from vegaprotocol/Vegaklaus-patch-22
5868214 
Update 0011-NP-CLIE-client-interaction-tests.md
@vega-paul
Update 0004-AMND-amends.md (#1606)
91df5df 
* Update 0004-AMND-amends.md

* Update 0004-AMND-amends.md

* Update 0004-AMND-amends.md

* Update 0004-AMND-amends.md

* Update 0004-AMND-amends.md
@jgsbennett @gordsport
fix: Relabel existing PLUP mainnet case to reflect the fact that it i…
add89fa 
…s only valid once PLUP-compatible versions are deployed. Add a new case to cover what is worth testing now, namely, that our best guess is that mainnet data is upgradable in future. (#1603)

Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com>
@Vegaklaus
Update 0069-VCBS-validators_chosen_by_stake.md
b723d50
@MuthuVega
chore: Amend acceptance criteria to cosmic elevator
b1d4b45
@ValentinTrinque
Merge pull request #1618 from vegaprotocol/amend_clie_acceptance_crit…
7bdcd01 
…eria

chore: Amend acceptance criteria to cosmic elevator
@Vegaklaus
Create multis user update
e8ab6d6
@Vegaklaus Vegaklaus marked this pull request as draft March 10, 2023 12:54
@Vegaklaus
Copy link
Contributor Author

One other option: Don't have an explicit evaluate function, but evaluate every time someone votes (shouldn't make any significant difference)

@gordsport gordsport changed the base branch from master to cosmicelevator March 15, 2023 10:28
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Mar 15, 2023
@gordsport gordsport linked an issue Mar 29, 2023 that may be closed by this pull request
Multisig improvements for scaling #1503
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0deMunk33 C0deMunk33 Awaiting requested review from C0deMunk33

@emilbayes emilbayes Awaiting requested review from emilbayes

@jeremyletang jeremyletang Awaiting requested review from jeremyletang

At least 1 approving review is required to merge this pull request.

Assignees

@Vegaklaus Vegaklaus

Labels
None yet
Projects
None yet
Milestone
⏭️ Next TBC
Development

Successfully merging this pull request may close these issues.

Multisig improvements for scaling