Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0072-SPPW-spam-protection-PoW.md #1702

Open
wants to merge 257 commits into
base: palazzo
Choose a base branch
from
Open

Conversation

Vegaklaus
Copy link
Contributor

@Vegaklaus Vegaklaus commented May 16, 2023

Added Acs for pruning the mempool

close #1678 .

gordsport and others added 30 commits March 17, 2023 14:08
feat: Add new cases, mostly around eth changes during outages. A few …
chore: remove invalid and unimplemented use cases
* draft for SORD

* add AC for showing rejected reason

* typo

* execution flags on orders table

* add codes to SORD

* Update user-interface/7002-SORD-submit_orders.md

Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com>

* add link to docs

---------

Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com>
* Clarify rewards if multisig contains a key it should not

* fix: MD lint error

---------

Co-authored-by: gordsport <gordon@vegaprotocol.io>
feat: update FOK MO reduce-only
Co-authored-by: Tom <tom@vegaprotocol.io>
#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).
#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).
Deleted half an AC as discussed on slack (as the number for the performance score didn't make sense here)
* refactor: update ACs

* chore: tell approbation to leave me alone

* chore: try again

* refactor: rephrase AC

* refactor: clarify

* refactor: fix spelling
…nctionality to fetch csv files containing network history (#1659)

* feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history

* fix: spell checker

---------

Co-authored-by: gordsport <gordon@vegaprotocol.io>
Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com>
* spec: draft for time-based mempool pruning

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

* spec: spelling

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

* Spelling + clarify how block height is determined

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

* spec: add some additional ACs, remove mention of TxV4, clarify that transaction data includes block hash in addition to block height

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

* complete acceptance criteria

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

* fix typo

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>

---------

Signed-off-by: Elias Van Ootegem <elias@vega.xyz>
Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com>
* chore: Add decision notes template

Added a decision template based loosely on the [Any Decision Records](https://adr.github.io/madr/) template

Also updated some MD linting to allow sibling duplicated header titles and double spacing to make reading easier.

* fix: Spelling error
@gordsport gordsport requested review from peterbarrow and removed request for peterbarrow July 19, 2023 10:06
@@ -128,3 +128,6 @@ All Vega clients that submitted transactions can verify that their transaction h

- *Mempool pruning* Cause congestion in the mempool by submitting many transactions (perhaps from several parties). Submit a transaction `T` tied to block number `N_old`. Make sure the transactions causing congestion create sufficiently large `N_current`. At some point we'll have `N_old + spam.pow.numberOfPastBlocks < N_current` and the transaction `T` is removed from the mempool and never scheduled. (<a name="0072-SPPW-012" href="#0072-SPPW-012">0072-SPPW-012</a>)

- Run the network on the borderline of capacity by submitting as many transactions as the network can process (possibly from many processes), causing short congestion spikes in individual blocks, but overall no congestion. Log all removed transactions removed through pruning, and verify they for all removed transactions `T`, all satisfied the condition that the block `N_t T` was tied to satisfies `N_t + spam.pow.numberOfPastBlocks < N_kickout`, where `N_kickout` is the block number processed when the transaction got pruned. (<a name="0072-SPPW-013" href="#0072-SPPW-013">0072-SPPW-013</a>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rewording

@gordsport gordsport changed the base branch from master to palazzo September 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPEC ONLY] Add mempool pruning AC