Add AUTH v2 spec #1736
Open
Add AUTH v2 spec #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinTrinque
force-pushed
the
feat/wallet-auth-v2
branch
4 times, most recently
from
55245be
to
84cfe8d
Compare
ValentinTrinque
force-pushed
the
feat/wallet-auth-v2
branch
11 times, most recently
from
fc506bb
to
31bcf06
Compare
|
@vega-paul This PR moves some ACs from the AUTH spec to the non-protocol CLIE spec. I will need to renumber them as CLIE ACs and will make the changes to the text comments in the respective system test files. It would also be good for you to review the other CLIE ACs and add/update as you see fit. Lower priority for now in terms of implementation, however, it'd be good to get these in as the spec was very out-of-date |
ValentinTrinque
force-pushed
the
feat/wallet-auth-v2
branch
from
31bcf06
to
ed18324
Compare
vega-paul
previously approved these changes
Jun 23, 2023
Vegaklaus
reviewed
Jun 27, 2023
Vegaklaus
reviewed
Jun 27, 2023
ValentinTrinque
force-pushed
the
feat/wallet-auth-v2
branch
from
9c9e36a
to
490a44d
Compare
ValentinTrinque
force-pushed
the
feat/wallet-auth-v2
branch
from
490a44d
to
9aa558b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec is supposed to explain the way we authenticate parties on the network, using public keys system. That part has been clarified. Details about the cryptographic algorithms used to generate such keys has been added. The high-level description of a "component" managing such keys, renamed wallet management application (prior wallet service) has been updated.
However, the previous version also explain how a user would interact with the wallet service, from an implementation perspective. This is doesn't fit anymore, as the interaction between the user and the wallet doesn't relate to the "authentication" of a user and a party on the network. As a result, the wallet API ACs has been moved out of that spec, to a non-protocol spec.
Close #1575