fix: correct the AC requirement to match the correct behaviour #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sohill-Patel
previously approved these changes
Jan 10, 2024
gordsport
force-pushed
the
correct-0019_MCAL-092-AC
branch
from
227b30e
to
3a87cbd
Compare
Sohill-Patel
previously approved these changes
Jan 12, 2024
Sohill-Patel
previously approved these changes
Jan 12, 2024
Sohill-Patel
previously approved these changes
Jan 12, 2024
witgaw
pushed a commit
that referenced
this pull request
Jan 15, 2024
* fix: correct the AC requirement to match the correct behaviour * feat: corrected ac and added 2 more * fix: duplicated AC codes * fix: json syntax error * fix: Extra AC codes --------- Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com>
gordsport
added a commit
that referenced
this pull request
Feb 22, 2024
* feat: remove redundant AC 013 * feat: address comments * feat: remove duplicated ACs * feat: remove duplicated ACs * feat: rename network parameter FeeDiscountDecay * feat: add governance proposal change market name * chore: typo * feat: address comments * feat: typo * chore: add ACs to features file for overnance proposal market name * Insurance pools of closed / settled markets to go to on - chain treasury (#2065) * feat: insurance pool redistribution * feat: add more updates * chore: markdown * chore: remove old AC * feat: address comments Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: address comments Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: address comments * feat: update spec 0015 * chore: markdown * chore: typo --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: add more ACs to isolated margin * chore: markdown * chore: markdown * feat: add more ACs * chore: markdown * chore: markdown * chore: typo * feat: address comments * chore: typo * Remove a duplicate AC (#2073) * fix: Removed duplicate AC * fix: Removed duplicate AC * fix: formula in ac * fix: diff twap if auct was included * feat: tidy up and add more ACS * chore: reorder * chore: format * fix: MD and spelling checks * feat: add ACs for switch margin modes * feat: update closeout * feat: update closeout * chore: remove mystery AC * feat: address commments from Tom * chore: typo * fix: AC 0053-PERP-030 now flexes the boundary * fix: formatting * Update protocol/0053-PERP-product_builtin_perpetual_future.md Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com> * fix: another formatting issue * feat: A couple more ACs, API clarifications and Removing excessive margin check (#2076) * feat: add alias to public keys * feat: add allow list to teams * feat: align spec with core change adding JoinTeam * chore: assign ac codes * chore: remove mentions of alias * feat: stop order position linked (#2043) * feat: Stop order changes * fix: correct expected behaviour * chore: duplicate ac * fix: address comments * feat: update for pegged order in isolated margin * feat: update json * chore: markdown * feat: more margin pegged order acs * fix: typo marging > margin * fix: duplicate ac code * fix: more marging typo * refactor: remove two acs * chore: add 165 back in * chore: position of ac corrected for diff * feat: update AC * feat: add back pegged order AC * chore: markdown * chore: typo * feat: update market state duing name changing * feat: address comment * chore: typo * feat: mark price updates ACs * fix: replace withdrawal limit > maximumLifetimeDeposit * fix: spellcheck * feat: update meaning of closed and allow_list team fields (#2090) * feat: change meaning of closed and allow_list * chore: reassign AC codes * fix: update wordlist * feat: add two system-test acs * feat: clarify market has no pm params * fix: update ac numbers * fix: still dup ac numbers * feat: update AC and add more AC * chore: tidy up * chore: markdown * feat: address comments * chore: markdown * chore: add timing * chore: typo * chore: Add AC code to the featurtes.json Also sneaking in a categories tidy up * fix: duplicated AC codes in features.json * feat: address comment * feat: EthL2s * fix: better name * fix: clarity on what is meant by L2 * chore: add initial AC codes and fix linting * fix: codeblock formatting * fix: milestone name * chore: Add ACs from the Eth spec to the L2 spec * fix: review comment * fix: MD linting * fix: approbation linting * fix: clarity on what is meant by L2 * feat: few acs for stop orders in auction * fix: updated ac numbers * fix: still dup acs * fix: removed AC codes and add L2 clarification * feat: added one more ac * feat: add acs for network profit and loss * fix: update for markdownlint * fix: update for spellcheck * fix: clarity on what is meant by L2 * fix: MD linting and add AC code to file * fix: MD linting and spellings * fix: spelling linting * chore: add AC code to existing AC (#2102) Adds an AC code to an AC that had one missing. * feat: add more acs * feat: add ac for first mark price * chore: markdown * feat: add more ac * feat: update AC 001 * chore: address comments Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * chore: address comment * chore: typo * feat: add more AC for validation * chore: typo * chore: markdown * chore: address comment * feat: add validation ac for mark price * fix: post-research call edits * refactor: scale funding payment down (auction) * refactor: apply suggestions from code review Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * feat: add liquidation acs * fix: correct typo in features * chore: update AC codes for rebase * fix: markdown * feat: add AC 126 * chore: Add more perps funding ACs (#2110) * chore: Add more perps funding ACs Adds more perps funding ACs from the AC review meeting Note the ACs mentioned for: - vegaprotocol/vega#10254 - vegaprotocol/vega#10255 Have NOT yet been added as the core side work has not been scheduled. A note has been added to the core issue * chore: Add AC code to the features.json file * fix: spelling * fix: spelling * fix: more spelling * fix: AC wording Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * fix: add missing AC codes to the featurews.json file Adds in the missing margin, markprice and perp AC codes * chore: Add ACs from the LP fee setting AC review meeting (#2115) * chore: Add ACs from the LP fee setting AC review meeting This PR adds new ACs from the LP fee setting AC review meeting. * fix: add codes to features.json * fix: add AC clarification * fix: wording from review comment Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * fix: fill in value --------- Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * fix: liq fee setting method market update * chore: comment out the cosmic-carryover (#2120) * chore: comment out the cosmic-carryover This comments out the cosmic carry over ACs so that the approbation stats reflect just the palazzo ACs * fix: syntax error * feat: more validation acs * fix: correct the AC requirement to match the correct behaviour (#2111) * fix: correct the AC requirement to match the correct behaviour * feat: corrected ac and added 2 more * fix: duplicated AC codes * fix: json syntax error * fix: Extra AC codes --------- Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com> * chore: update features.json (#2123) In order to have the correct reporting on palazzo AC coverage I have remove some ACs that will NOT be done: insurance pool re-dist: 0073-LIMN-115 0073-LIMN-116 0073-LIMN-117 perps/sucessor markets: 0015-INSR-005 0081-SUCM-036 We do not support sucessor and perps and we are not supporting LNL * chore: split AC code 056 into 3 (#2126) Splits the AC code 056 into 3 parts and adds one new AC. All to be done as system tests * chore: adds AC from the isolated margin AC review (#2125) * chore: adds AC from the isolated margin AC review Adds in protocol upgrade AC coverage for isolated margin as per the isolated margin AC review meeting * chore: Update AC to be more clear Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com> --------- Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com> * chore Update features.json to add missing AC code (#2127) * chore Update features.json to add missing AC code Adds the following missing AC to the features file: "0087-EVMD-043" * fix: remove "0053-PERP-036", as its a nebula AC * chore: add more position stop order AC codes (#2109) * chore: add more position stop order AC codes Adds in ACs from the position stop orders feature AC review * fix: linting checks * fix: review comment * fix: reduce ethereum rpc data source flexibility * fix: reduce ethereum rpc data source flexibility * fix: AC code approbation check fail * feat: add AC 003 for mark price * chore: update json file * feat: update ac 027 * chore: grammar * feat: update initial margin level in isolated margin * chore: grammar Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * chore: typo Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> * feat: change tau scaling bound * feat: update bound * feat: update probability of trading in LP score * chore: address comment Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> * chore: markdown * chore: descope AC 0053-PERP-035 from Palazzo (#2135) based on a research / protocol design discussion this PR descopes AC 0053-PERP-035 from Palazzo * fix: Updating AC to cover wrong side stop orders being rejected * feat: add party profile feature * feat: add anti alias squatting feature * Revert "feat: add anti alias squatting feature" This reverts commit 6c3f548. * chore: correct restriction typos * feat: add validation and defaults for new network parameters * feat: add ac for price via data node * feat: update json file * chore: remove ACs from palazzo (#2140) 0009-MRKP-133 and 0053-PERP-043 will be moved to Nebula in a new PR * refactor: update liquidation price estimate * chore: add feature file for 0012-NP-LIPE ACs * refactor: add spec for position estimate * chore: Update features.json * chore: renove dupe AC from features file (#2151) * chore: add deatails about the max proposals in a batch This updates the spec to details the max number of proposals that can be submitted in a single batch proposal * chore: add teams spam protection (#2157) Copies the changes made to the Colosseo branch here: - #2156 * feat: add ac to 0019 * chore: add features.json entries * fix: dupe ACs * chore: add update team spam ACs (#2159) * chore: add update team spam ACs Adds in ACs for also updating referral sets / teams and spam protection * fix: spelling * chore: Update protocol/0062-SPAM-spam_protection.md Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> * chore: Update protocol/features.json Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> * fix: net param name --------- Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> * feat: add more ACs * chore: typo * feat: market update ACs for mark price and perps price (#2171) * feat: market update ACs for mark price and perps price * feat: market update ACs for mark price and perps price * feat: market update ACs for mark price and perps price * feat: market update ACs for mark price and perps price * feat: market update ACs for mark price and perps price * feat: market update ACs for mark price and perps price * chore: add ACs to feature.json file --------- Co-authored-by: gordsport <gordon@vegaprotocol.io> * refactor: AC clarifications * refactor: amend 0012-NP-LIPE-005 * refactor: clarify and extend liquidation ACs * refactor: additional clarifications * feat: Add extra validator ranking reward metric AC (#2174) * feat: Add extra validator ranking reward metric AC Adds an extra validator ranking reward metric AC: For reward metrics relating to trading, an individual must meet the staking requirement AND notional time-weighted average position requirement) set in the recurring transfer. If they do not then their reward metric is set to 0. Note, these requirements do not apply to the validator ranking metric or the market creation reward metric. e.g. For a party that is a consensus or standby validator, the staking requirement and notional time-weighted average position requirement do not apply to their validator ranking metric * chore: split AC into 3 * fix: remove old AC * refactor: amend a few perp ACs * chore: remove dup ac * refactor: modify AC * feat: clarify and add ac for gov suspend and resume * fix: duplicate ac code * fix: dup ac codes * fix: conflicts and spell / md lint checks * fix: missed dupe ACs * chore: remove spot --------- Co-authored-by: Jiajia-Cui <jiajia@vega.xyz> Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com> Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com> Co-authored-by: Pete Barrow <62435083+peterbarrow@users.noreply.github.com> Co-authored-by: Sohill-Patel <85170301+Sohill-Patel@users.noreply.github.com> Co-authored-by: Witold <witold@vega.xyz> Co-authored-by: wwestgarth <william@vega.xyz> Co-authored-by: wwestgarth <westgarth.w@gmail.com> Co-authored-by: Tom <tom@vegaprotocol.io> Co-authored-by: Charlie <charlie@vegaprotocol.io> Co-authored-by: Charlie <99198652+cdummett@users.noreply.github.com> Co-authored-by: Witold <gawlikowicz@gmail.com> Co-authored-by: candida-d <62548908+candida-d@users.noreply.github.com> Co-authored-by: Pete Barrow <pete@vega.xyz> Co-authored-by: Jeremy Letang <me@jeremyletang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the AC code to match implementation and the correct behaviour