Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate fee discount components #2293

Merged
merged 11 commits into from
Jul 15, 2024
Merged

feat: separate fee discount components #2293

merged 11 commits into from
Jul 15, 2024

Conversation

TomMcL
Copy link
Contributor

@TomMcL TomMcL commented Jun 4, 2024 •
edited
Loading

Closes #2292

@TomMcL TomMcL marked this pull request as ready for review June 6, 2024 10:12
cdummett
cdummett requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks about consistency of parameter names.

The formulas and mechanics seem good to me though 👍

protocol/0029-FEES-fees.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0083-RFPR-on_chain_referral_program.md Outdated Show resolved Hide resolved
protocol/0084-VDPR-volume_discount_program.md Outdated Show resolved Hide resolved
@TomMcL TomMcL requested a review from cdummett June 6, 2024 17:00
ze97286
ze97286 reviewed Jul 3, 2024
View reviewed changes
protocol/0029-FEES-fees.md Outdated

The infrastructure fee factor is set by a network parameter `market.fee.factors.infrastructureFee` and a reasonable default value is `fee_factor[infrastructure] = 0.0005 = 0.05%`.
The maker fee factor is set by a network parameter `market.fee.factors.makerFee` and a reasonable default value is `fee_factor[maker] = 0.00025 = 0.025%`.
The liquidity fee factor is set by an auction-like mechanism based on the liquidity provisions committed to the market, see [setting LP fees](./0042-LIQF-setting_fees_and_rewarding_lps.md).
The treasury fee factor is set by the network parameter `market.fee.factors.treasuryFee`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid/default values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 0 for both

witgaw
witgaw reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just unsure about the formula.

protocol/0029-FEES-fees.md Outdated Show resolved Hide resolved
protocol/0095-HVMR-high_volume_maker_rebate.md Show resolved Hide resolved
@ze97286 ze97286 mentioned this pull request Jul 4, 2024
Open
This was linked to issues Jul 8, 2024
Volume discount spec update to better target maker rebate #2292
Closed
Add dynamic maker fee based on maker's volume #2296
Closed
@witgaw witgaw force-pushed the feat/separate_fee_discount_components branch from 77de206 to e45cba1 Compare July 12, 2024 18:02
@JonRay15 JonRay15 mentioned this pull request Jul 15, 2024
Open
@davidsiska-vega davidsiska-vega merged commit 0e9ab96 into colosseo_II Jul 15, 2024
4 checks passed
@davidsiska-vega davidsiska-vega deleted the feat/separate_fee_discount_components branch July 15, 2024 13:37
This was referenced Jul 17, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ze97286 ze97286 ze97286 left review comments

@witgaw witgaw witgaw left review comments

@cdummett cdummett cdummett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dynamic maker fee based on maker's volume Volume discount spec update to better target maker rebate
5 participants
@TomMcL @ze97286 @witgaw @cdummett @davidsiska-vega