Merge pull request #10866 from vegaprotocol/10739

fix: hanlde loading from snapshot when all markets have been settled …

CHANGELOG.md

@@ -57,6 +57,7 @@
 - [10837](https://github.com/vegaprotocol/vega/issues/10837) - List transfers API can error when pagination is provided.
 - [10823](https://github.com/vegaprotocol/vega/issues/10823) - Only allowing a single trigger to be breached when checking bounds.
 - [10055](https://github.com/vegaprotocol/vega/issues/10055) - Quitting the wallet service CLI while waiting for a password now restores the terminal capabilities.
+- [10739](https://github.com/vegaprotocol/vega/issues/10739) - Fix loading from snapshot when all markets have been settled before the loaded snapshot. 
 
 ## 0.74.3
 

core/snapshot/engine.go

@@ -593,7 +593,11 @@ func (e *Engine) snapshotNow(ctx context.Context, saveAsync bool) ([]byte, DoneC
 		resultByTreeKey[string(tkRes.input.treeKey)] = tkRes
 	}
 
-	for _, ns := range e.registeredNamespaces {
+	nsSlice := make([]types.SnapshotNamespace, len(e.registeredNamespaces))
+	copy(nsSlice, e.registeredNamespaces)
+	sort.Slice(nsSlice, func(i, j int) bool { return nsSlice[i] < nsSlice[j] })
+
+	for _, ns := range nsSlice {
 		treeKeys, ok := e.namespacesToTreeKeys[ns]
 		if !ok {
 			continue

core/types/governance_new_spot_market.go

@@ -392,21 +392,24 @@ type SpotProduct struct {
 
 func (f SpotProduct) IntoProto() *vegapb.SpotProduct {
 	return &vegapb.SpotProduct{
+		Name:       f.Name,
 		BaseAsset:  f.BaseAsset,
 		QuoteAsset: f.QuoteAsset,
 	}
 }
 
 func (f SpotProduct) DeepClone() *SpotProduct {
 	return &SpotProduct{
+		Name:       f.Name,
 		BaseAsset:  f.BaseAsset,
 		QuoteAsset: f.QuoteAsset,
 	}
 }
 
 func (f SpotProduct) String() string {
 	return fmt.Sprintf(
-		"baseAsset(%s) quoteAsset(%s)",
+		"name(%s) baseAsset(%s) quoteAsset(%s)",
+		f.Name,
 		f.BaseAsset,
 		f.QuoteAsset,
 	)