Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Panic on fairground #10177

Closed
wwestgarth opened this issue Nov 27, 2023 · 0 comments · Fixed by #10178
Closed

[Bug]: Panic on fairground #10177

wwestgarth opened this issue Nov 27, 2023 · 0 comments · Fixed by #10178

Comments

@wwestgarth
Copy link
Contributor

Problem encountered

The below panic occurred on fairgraound:

Nov 26 12:13:45 n01.testnet.vega.rocks visor[3758517]: 2023-11-26T12:13:45.470Z        ERROR        tendermint        consensus/state.go:732        CONSENSUS FAILURE!!!        {"err": "cannot unregister order with potential sell + size change < 0", "stack": "goroutine 490 [running]:
runtime/debug.Stack()
    /opt/hostedtoolcache/go/1.20.11/x64/src/runtime/debug/stack.go:24 +0x65
github.com/tendermint/tendermint/consensus.(*State).receiveRoutine.func2()
    /home/runner/go/pkg/mod/github.com/vegaprotocol/cometbft@v0.34.29-patch.1/consensus/state.go:732 +0x4c
panic({0x31776e0, 0xc01e972ef0})
    /opt/hostedtoolcache/go/1.20.11/x64/src/runtime/panic.go:884 +0x213
go.uber.org/zap/zapcore.CheckWriteAction.OnWrite(0x2?, 0x2?, {0x0?, 0x0?, 0xc011debc40?})
    /home/runner/go/pkg/mod/go.uber.org/zap@v1.24.0/zapcore/entry.go:198 +0x65
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc01987a270, {0xc014644f80, 0x2, 0x2})
    /home/runner/go/pkg/mod/go.uber.org/zap@v1.24.0/zapcore/entry.go:264 +0x3ec
go.uber.org/zap.(*Logger).Panic(0x2?, {0x3b55544?, 0x2?}, {0xc014644f80, 0x2, 0x2})
    /home/runner/go/pkg/mod/go.uber.org/zap@v1.24.0/logger.go:258 +0x59
code.vegaprotocol.io/vega/core/positions.(*MarketPosition).UpdateOnOrderChange(0xc0122f1090, 0xc00dba7860, 0x8881798?, 0xc034f3c360, 0x7ffffffffff0bdbf, 0x0)
    /home/runner/work/vega/vega/core/positions/market_position.go:106 +0x897
code.vegaprotocol.io/vega/core/positions.(*MarketPosition).UnregisterOrder(0x32a6bc0?, 0xc00dba7890?, 0xc021351200?)
    /home/runner/work/vega/vega/core/positions/market_position.go:75 +0x45
code.vegaprotocol.io/vega/core/positions.(*Engine).UnregisterOrder(0xc00db8af00, {0x41cfe50, 0xc0341c42d0}, 0xc01ced7ee0)
    /home/runner/work/vega/vega/core/positions/engine.go:239 +0x23c
code.vegaprotocol.io/vega/core/execution/future.(*Market).submitValidatedOrder(0xc00dbdc300, {0x41cfe50, 0xc0341c42d0}, 0xc01ced7ee0)
    /home/runner/work/vega/vega/core/execution/future/market.go:2074 +0xd5c
code.vegaprotocol.io/vega/core/execution/future.(*Market).submitOrder(0xc00dbdc300, {0x41cfe50, 0xc0341c42d0}, 0xc01ced7ee0)
    /home/runner/work/vega/vega/core/execution/future/market.go:1943 +0x24e
code.vegaprotocol.io/vega/core/execution/future.(*Market).SubmitOrderWithIDGeneratorAndOrderID(0xc00dbdc300, {0x41cfe50, 0xc0341c42d0}, 0xc012ccf500?, {0xc021351200, 0x40}, {0x419bec0?, 0xc01e30b128?}, {0xc014336d80, 0x40}, ...)
    /home/runner/work/vega/vega/core/execution/future/market.go:1906 +0x525
code.vegaprotocol.io/vega/core/execution.(*Engine).SubmitOrder(0xc0014c02c0, {0x41cfe50, 0xc0341c42d0}, 0xc01e670a20, {0xc021351200, 0x40}, {0x419bec0, 0xc01e30b128}, {0xc014336d80, 0x40})

Observed behaviour

Network panic when trying to close entire position.

Expected behaviour

Not network panic when trying to close entire position.

Steps to reproduce

1. Submit `xyz` transaction
2. With this payload
3. Query `abc` API
4. Observe the error

Software version

v0.73.6

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants