fix: validate against large order sizes that may caught internal over… #10178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze97286
reviewed
Nov 27, 2023
wwestgarth
force-pushed
the
10177-fix-overflow
branch
from
ae372d4
to
e162a4b
Compare
wwestgarth
force-pushed
the
10177-fix-overflow
branch
from
e162a4b
to
6960feb
Compare
EVODelavega
approved these changes
Nov 27, 2023
jeremyletang
pushed a commit
that referenced
this pull request
Nov 27, 2023
fix: validate against large order sizes that may caught internal over…
jeremyletang
pushed a commit
that referenced
this pull request
Dec 1, 2023
fix: validate against large order sizes that may caught internal over…
jeremyletang
pushed a commit
that referenced
this pull request
Dec 9, 2023
fix: validate against large order sizes that may caught internal over…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10177
Adds validation that the order size that we might be regsitering with the position engine isn't so large that it'll cause us to overflow. We do this both in command validation, and order valiation in the execution engine.
If we do somehow have an order that makes its way through, we now panic ealier with more helpful error-text.