Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework wallet file implementation to embed permissions #5541

Closed
ValentinTrinque opened this issue Jul 6, 2022 · 0 comments · Fixed by #5544
Closed

Rework wallet file implementation to embed permissions #5541

ValentinTrinque opened this issue Jul 6, 2022 · 0 comments · Fixed by #5544
Assignees
Labels

Comments

@ValentinTrinque
Copy link
Contributor

I tried to implement the permissions system without touching to the current implementation of the wallet, to lower the amount of work. But, now, I realise that the permissions file and the wallet file can get desynchronised in ways I really didn’t anticipated (example: keys specified in the permissions file might have been removed from the wallet file, the wallet file could also be renamed, a different wallet could have the same name as the one in the permissions file but with different keys, etc).

Trying to handle these problems with my current implementation (2 separate files) creates all kind of UX problem and fragile error handling.

As a result, I need to embed the permissions inside the wallet file. This way I can enforce strong consistency between permissions and keys, and bypass all wallet rename problem. Also, it makes the backup of the wallet and its associated permissions much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants