Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API]: Add fee to transfers objects in GraphQL & REST #8056

Closed
3 of 6 tasks
edd opened this issue Mar 31, 2023 · 1 comment · Fixed by #9865 or #10288
Closed
3 of 6 tasks

[API]: Add fee to transfers objects in GraphQL & REST #8056

edd opened this issue Mar 31, 2023 · 1 comment · Fixed by #9865 or #10288
Assignees
Labels
api enhancement New feature or request fe-request A list of reasonably high value API change requests from front end size-large transfers

Comments

@edd
Copy link
Member

edd commented Mar 31, 2023

Warning

Reopened as it is not possible in GraphQL to get the fee for an individual transfer

https://github.com/vegaprotocol/vega/blob/develop/datanode/gateway/graphql/schema.graphql#L718-L755

In GraphQL and REST, it is not possible to know what they fee paid for a transfer is. You can guess by looking at a network parameter, but that is unreliable for transfers in the past as the factor could have changed.

Changes

  • A new field should represent the fee paid for a transfer
  • The fee should be the value in the same asset as the transfer
  • The fee should not be the fee factor, but the actual amount paid for the transfer

Tasks

@edd edd added enhancement New feature or request api transfers labels Mar 31, 2023
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Apr 4, 2023
@edd edd added the fe-request A list of reasonably high value API change requests from front end label Aug 1, 2023
@edd edd reopened this Dec 13, 2023
@edd
Copy link
Member Author

edd commented Dec 13, 2023

Reopened. In GraphQL, the fees are not exposed by the { transfer(id:"123"){...} } query. They are exposed by { transfersConnection(partyId:"456"){...} }, but the trransfersConnection query does not support selecting by ID

Tasks

  • Add fees to query { transfer(){ ... } } } response in GraphQL

@JonRay15 JonRay15 changed the title Add fee to transfers objects in GraphQL & REST [API]: Add fee to transfers objects in GraphQL & REST Dec 13, 2023
@JonRay15 JonRay15 assigned EVODelavega and unassigned EVODelavega Dec 13, 2023
@ValentinTrinque ValentinTrinque self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request fe-request A list of reasonably high value API change requests from front end size-large transfers
Projects
Archived in project
4 participants