Parties allowed to change markets with 0% equity like share

[gordsport]

Scenario

    Verify that if governance.proposal.market.minEquityLikeShare = 0 and if a party meets the
    governance.proposal.updateMarket.minProposerBalance threshold then said party can submit
    a market change proposal. (0028-GOVE-060)
    Negative case when governance.proposal.updateMarket.minProposerEquityLikeShare is > 0

Party proposed a market, party has 0% ELS
Second party updates the market - second party has 0% ELS
Update market proposal should reject but instead it Enacts with votes

Test test_upd_mkt_positive_minEquityLikeShare
https://jenkins.ops.vega.xyz/job/common/job/system-tests-nightly/989/testReport/junit/tests.governance/test_update_market_proposal/Call_tests___full_g_n___test_upd_mkt_positive_minEquityLikeShare/

NP change minProposerEquityLikeShare to 0.5%

{"id":"4521-18","block":"766F03EE46AF432DC7DA4907AC734AC03F8648A3F5DD9A001EBABE3048272455","type":"BUS_EVENT_TYPE_PROPOSAL","proposal":{"id":"4afc59b31f5207e03ac2e29b6d7eb750300b860b5f32cd9278c5697a72e2131a","reference":"2C9416D0F2","partyId":"e65d2f9e1c17068bb57c3ac7f0a100f2641b58ffecb20ad3fab773aeed48a809","state":"STATE_ENACTED","timestamp":"1688377103506724000","terms":{"closingTimestamp":"1688377107","enactmentTimestamp":"1688377107","updateNetworkParameter":{"changes":{"key":"governance.proposal.updateMarket.minProposerEquityLikeShare","value":"0.5"}}},"rationale":{"description":"Update network parameter","title":"Network Param Update: governance.proposal.updateMarket.minProposerEquityLikeShare"},"requiredParticipation":"0.00000015","requiredMajority":"0.66"},"version":1,"chainId":"testnet-001","txHash":"766F03EE46AF432DC7DA4907AC734AC03F8648A3F5DD9A001EBABE3048272455"}

Market proposal

{"id":"4533-9","block":"6C40C23ADB6CD12363B09DB687FC4482F36F7A6544C5152D442FBA978251D046","type":"BUS_EVENT_TYPE_PROPOSAL","proposal":{"id":"7d49105925ee41772488240622df98ddb66b416d8ea44fc9296cc62e6358ddf6","reference":"0C57FCD524","partyId":"0b3cff56561bb5507f31e3fbc0eff9e319f19ce00cbecf513fafdd05ddbdfac3","state":"STATE_ENACTED","timestamp":"1688377109960140000","terms":{"closingTimestamp":"1688377113","enactmentTimestamp":"1688377114","newMarket":{"changes":{"instrument":{"name":"Futures System-Tests Market","code":"CRYPTO:VEGA CORE SYS TEST","future":{"settlementAsset":"278d50e963de9154a2881fb3b1e666d000b614c67418c7f58fbd5a02a22f1c99","quoteName":"USD","dataSourceSpecForSettlementData":{"external":{"oracle":{"signers":[{"pubKey":{"key":"0b3cff56561bb5507f31e3fbc0eff9e319f19ce00cbecf513fafdd05ddbdfac3"}}],"filters":[{"key":{"name":"oracle.test.settlement729D3","type":"TYPE_INTEGER","numberDecimalPlaces":"5"},"conditions":[{"operator":"OPERATOR_GREATER_THAN_OR_EQUAL","value":"0"}]}]}}},"dataSourceSpecForTradingTermination":{"external":{"oracle":{"signers":[{"pubKey":{"key":"0b3cff56561bb5507f31e3fbc0eff9e319f19ce00cbecf513fafdd05ddbdfac3"}}],"filters":[{"key":{"name":"oracle.test.terminationD7E05","type":"TYPE_BOOLEAN"},"conditions":[{"operator":"OPERATOR_EQUALS","value":"True"}]}]}}},"dataSourceSpecBinding":{"settlementDataProperty":"oracle.test.settlement729D3","tradingTerminationProperty":"oracle.test.terminationD7E05"}}},"decimalPlaces":"5","metadata":["asset_class:fx/crypto","product:futures"],"priceMonitoringParameters":{},"liquidityMonitoringParameters":{"targetStakeParameters":{"timeWindow":"10","scalingFactor":5},"triggeringRatio":"0","auctionExtension":"1"},"logNormal":{"riskAversionParameter":0.001,"tau":0.00011407711613050422,"params":{"r":0.016,"sigma":1.5}},"positionDecimalPlaces":"5","lpPriceRange":"1","linearSlippageFactor":"0.01","quadraticSlippageFactor":"0"}}},"rationale":{"description":"Proposal submitted to enact a new Market","title":"Market Proposal"},"requiredParticipation":"0.00000015","requiredMajority":"0.66"},"version":1,"chainId":"testnet-001","txHash":"6C40C23ADB6CD12363B09DB687FC4482F36F7A6544C5152D442FBA978251D046"

Market data with ELS

{"id":"4534-8","block":"2FB175EBEBEB2A12BC06B8EDBA197D1AFDE0B15684192A48A136EDF40AF84C1C","type":"BUS_EVENT_TYPE_MARKET_DATA","marketData":{"markPrice":"0","bestBidPrice":"0","bestOfferPrice":"0","bestStaticBidPrice":"0","bestStaticOfferPrice":"0","midPrice":"0","staticMidPrice":"0","market":"7d49105925ee41772488240622df98ddb66b416d8ea44fc9296cc62e6358ddf6","timestamp":"1688377115632140000","auctionEnd":"1688377114000000000","auctionStart":"1688377113000000000","indicativePrice":"0","marketTradingMode":"TRADING_MODE_OPENING_AUCTION","trigger":"AUCTION_TRIGGER_OPENING","targetStake":"0","suppliedStake":"0","marketValueProxy":"0","marketState":"STATE_PENDING","nextMarkToMarket":"-6795364578871345152","lastTradedPrice":"0","marketGrowth":"0"},"version":1,"chainId":"testnet-001","txHash":"2FB175EBEBEB2A12BC06B8EDBA197D1AFDE0B15684192A48A136EDF40AF84C1C"}

Update market

{"id":"4544-18","block":"485BE545FA079D7F45C70E83DD48008E3024062DEEB99A889FF0160BE8E04700","type":"BUS_EVENT_TYPE_PROPOSAL","proposal":{"id":"df7f888120ab67c03a161f66888e51e095d2c6dcd032d0790bbc720d03c16767","reference":"FAF6062576","partyId":"fe14de45af880e8abc3defb702103d8b8ca6bba90352893b11ad2754ae2e965d","state":"STATE_ENACTED","timestamp":"1688377116925600000","terms":{"closingTimestamp":"1688377120","enactmentTimestamp":"1688377120","updateMarket":{"marketId":"7d49105925ee41772488240622df98ddb66b416d8ea44fc9296cc62e6358ddf6","changes":{"instrument":{"code":"CRYPTO:VEGA CORE SYS TEST","future":{"quoteName":"USD","dataSourceSpecForSettlementData":{"external":{"oracle":{"signers":[{"pubKey":{"key":"0b3cff56561bb5507f31e3fbc0eff9e319f19ce00cbecf513fafdd05ddbdfac3"}}],"filters":[{"key":{"name":"oracle.test.settlement729D3","type":"TYPE_INTEGER","numberDecimalPlaces":"5"},"conditions":[{"operator":"OPERATOR_GREATER_THAN_OR_EQUAL","value":"0"}]}]}}},"dataSourceSpecForTradingTermination":{"external":{"oracle":{"signers":[{"pubKey":{"key":"0b3cff56561bb5507f31e3fbc0eff9e319f19ce00cbecf513fafdd05ddbdfac3"}}],"filters":[{"key":{"name":"oracle.test.terminationD7E05","type":"TYPE_BOOLEAN"},"conditions":[{"operator":"OPERATOR_EQUALS","value":"True"}]}]}}},"dataSourceSpecBinding":{"settlementDataProperty":"oracle.test.settlement729D3","tradingTerminationProperty":"oracle.test.terminationD7E05"}}},"metadata":["asset_class:fx/crypto","product:futures"],"priceMonitoringParameters":{},"liquidityMonitoringParameters":{"targetStakeParameters":{"timeWindow":"10","scalingFactor":5},"triggeringRatio":"0","auctionExtension":"1"},"logNormal":{"riskAversionParameter":0.001,"tau":0.00011407711613050422,"params":{"r":0.016,"sigma":1.5}},"lpPriceRange":"1","linearSlippageFactor":"0.01","quadraticSlippageFactor":"0"}}},"rationale":{"description":"Update market","title":"Market Update Proposal: 278d50e963de9154a2881fb3b1e666d000b614c67418c7f58fbd5a02a22f1c99"},"requiredParticipation":"0.00000015","requiredMajority":"0.66","requiredLiquidityProviderParticipation":"0.00001","requiredLiquidityProviderMajority":"0.66"},"version":1,"chainId":"testnet-001","txHash":"485BE545FA079D7F45C70E83DD48008E3024062DEEB99A889FF0160BE8E04700"}

[gordsport]

@vega-paul - transferred from:

• https://github.com/vegaprotocol/system-tests/issues/2226

Can you detail the version / commit hash this bug has been noticed from and any other useful bug info etc...

[gordsport]

@vega-paul - can you confirm this has been tested using a version that has this fix in:

• feat: allow update market proposal submission with only ELS #8638

[vega-paul]

@gordsport @jeremyletang The regression is related to https://github.com/vegaprotocol/vega/pull/8638/commits