Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow update market proposal submission with only ELS #8638

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

jeremyletang
Copy link
Member

close #8635

@jeremyletang jeremyletang requested a review from a team as a code owner June 29, 2023 12:19
@EVODelavega
Copy link
Contributor

This change concerns me a bit, as it seems to go against one of the AC's, specifically 0028-GOVE-072 (https://github.com/vegaprotocol/specs/blob/cosmicelevator/protocol/0028-GOVE-governance.md#0028-GOVE-072):

A market change that's to modify any parameters on a market in pending state (i.e. voting has successfully completed on the market creation and the market is in the opening auction) will run voting rules the same as market creation proposals i.e. LPs don't get a vote.

@jeremyletang
Copy link
Member Author

This change concerns me a bit, as it seems to go against one of the AC's, specifically 0028-GOVE-072 (https://github.com/vegaprotocol/specs/blob/cosmicelevator/protocol/0028-GOVE-governance.md#0028-GOVE-072):

A market change that's to modify any parameters on a market in pending state (i.e. voting has successfully completed on the market creation and the market is in the opening auction) will run voting rules the same as market creation proposals i.e. LPs don't get a vote.

Yea the ACs might needs updating, but the PR is to implements the changes required here: vegaprotocol/specs#1768

Signed-off-by: Jeremy Letang <me@jeremyletang.com>
@EVODelavega EVODelavega merged commit 8d9828c into develop Jun 29, 2023
15 checks passed
@EVODelavega EVODelavega deleted the feature/8635 branch June 29, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow token holders to change a market without being an LP
2 participants