Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gas estimation to stop orders #8690

Closed
jeremyletang opened this issue Jul 5, 2023 · 1 comment · Fixed by #8691
Closed

Add gas estimation to stop orders #8690

jeremyletang opened this issue Jul 5, 2023 · 1 comment · Fixed by #8691
Assignees
@jeremyletang
Labels
feature new feature to be developed stop-orders
Milestone
☄️ Cosmic Elevator

Comments

@jeremyletang
Copy link
Member

jeremyletang commented Jul 5, 2023 •
edited

From @witgaw:

So I suppose we want the cost factor * number of stop orders to feature in gas calculation for any transaction and a limit across all markets (same as pegged)? If that’s the direction you want to take it I can draft a spec change.
@jeremyletang jeremyletang mentioned this issue Jul 5, 2023
Merged
@witgaw
Copy link
Member

witgaw commented Jul 5, 2023

That's what I drafted: vegaprotocol/specs#1806

@gordsport gordsport added stop-orders feature new feature to be developed labels Jul 5, 2023
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyletang jeremyletang

Labels
feature new feature to be developed stop-orders
Projects
Core Kanban
Archived in project
Milestone
☄️ Cosmic Elevator
Development

Successfully merging a pull request may close this issue.

feat: add gas support for stop orders vegaprotocol/vega
3 participants
@jeremyletang @witgaw @gordsport