Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include stop orders in gas calculations #1806

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Include stop orders in gas calculations #1806

merged 3 commits into from
Jul 12, 2023

Conversation

witgaw
Copy link
Member

@witgaw witgaw commented Jul 3, 2023

  • Include stop orders in gas calculations.
  • Remove LP shapes.

@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Jul 4, 2023
@gordsport gordsport requested a review from a team July 4, 2023 07:39
cdummett
cdummett previously approved these changes Jul 5, 2023
View reviewed changes
@witgaw witgaw mentioned this pull request Jul 5, 2023
Closed
barnabee
barnabee requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@barnabee barnabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add stop orders to the calculation of gas for a batch. They are a separate "section" of the batch submission.

@witgaw
Copy link
Member Author

witgaw commented Jul 6, 2023

Need to add stop orders to the calculation of gas for a batch. They are a separate "section" of the batch submission.

@barnabee is it not enough to just count them along with other cancellations / amendments / submissions?
6f53b4c

@witgaw witgaw force-pushed the stop-order-gas-limit branch 4 times, most recently from 1acfa67 to 7573887 Compare July 10, 2023 15:05
@witgaw witgaw requested a review from barnabee July 10, 2023 15:27
karlem
karlem reviewed Jul 10, 2023
View reviewed changes
protocol/0079-TGAP-transaction_gas_and_priority.md Outdated
@@ -87,7 +87,7 @@ gas = min((maxGas/minBlockCapacity)-1,batchGas)

```go
gasOliq = network.transaction.defaultgas + peg cost factor x pegs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LP submission, amendment and cancelation should not produce any orders anymore so why do we still need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, the gas is the same as for the the regular order submission so doesn't really matter, but I can remove that section.

@witgaw witgaw force-pushed the stop-order-gas-limit branch 2 times, most recently from 4be18a0 to 5e525d9 Compare July 11, 2023 11:09
@witgaw witgaw merged commit 04054f1 into cosmicelevator Jul 12, 2023
4 checks passed
@witgaw witgaw deleted the stop-order-gas-limit branch July 12, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlem karlem karlem left review comments

@barnabee barnabee barnabee approved these changes

@cdummett cdummett cdummett left review comments

Assignees

@witgaw witgaw

Labels
orders
Projects
None yet
Milestone
☄️ Cosmic Elevator
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@witgaw @barnabee @karlem @cdummett @gordsport