Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue to use market price for average entry prices #10037

Merged
merged 1 commit into from Nov 10, 2023

Conversation

wwestgarth
Copy link
Contributor

@wwestgarth wwestgarth commented Nov 10, 2023

closes #10036

If someone could check the numbers in the unittest make sense (they look of reasonable magnitude) that would be nice?

@wwestgarth wwestgarth force-pushed the 10036-average-entry-price-flicker branch 2 times, most recently from 7a5864a to 8d45421 Compare November 10, 2023 09:52
@wwestgarth wwestgarth marked this pull request as ready for review November 10, 2023 09:52
@wwestgarth wwestgarth requested a review from a team as a code owner November 10, 2023 09:52
@wwestgarth wwestgarth force-pushed the 10036-average-entry-price-flicker branch from 8d45421 to 4ba0d66 Compare November 10, 2023 10:45
@wwestgarth wwestgarth force-pushed the 10036-average-entry-price-flicker branch from 4ba0d66 to 0623284 Compare November 10, 2023 13:29
@EVODelavega EVODelavega merged commit ee6c0da into develop Nov 10, 2023
14 checks passed
@EVODelavega EVODelavega deleted the 10036-average-entry-price-flicker branch November 10, 2023 13:57
jeremyletang pushed a commit that referenced this pull request Nov 10, 2023
…-flicker

fix: continue to use market price for average entry prices
@gordsport gordsport added the bug label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Flickering average-entry price
3 participants